fix(icons): add the third batch of icon-saas icons. #3889

shenjunjian · 2025-12-09T02:55:47Z

PR

新增第三批icon-saas图标 ------------- 需要发runtime, 杨

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our Commit Message Guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Other information

Summary by CodeRabbit

New Features
- Added a third batch of icons to the library and integrated a second icons gallery in demos so users can browse and select from the expanded set with the same filtering and interaction behavior.
Documentation
- Minor whitespace cleanup in demo docs for clarity.
Chores
- Non-functional comment added to internal utility code for maintainability.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2025-12-09T02:56:02Z

Caution

Review failed

The pull request is closed.

Walkthrough

Adds a new exported icon array batch3Icons and renders it as a second icon gallery in two Vue demo components; also removes trailing blank lines from two markdown files and inserts a non-functional comment line in a grid utility file.

Changes

Cohort / File(s)	Summary
Icon Data Definition `examples/sites/demos/pc/app/icon/advance-icons.js`	Adds `export const batch3Icons = [...]` containing a large array of icon name strings alongside the existing `advanceIcons`.
Gallery Components `examples/sites/demos/pc/app/icon/advance-usage.vue`, `examples/sites/demos/pc/app/icon/advance-usage-composition-api.vue`	Import `batch3Icons` and render a second icon gallery (separated by `<hr/>`) that mirrors the existing grid layout and click-handling logic; exposes `batch3Icons` in component state as needed.
Docs Whitespace Fixes `examples/sites/demos/mobile-first/app/tree-select/webdoc/tree-select.cn.md`, `examples/sites/demos/mobile-first/app/tree-select/webdoc/tree-select.en.md`	Removed trailing blank lines at EOF (whitespace-only edits).
Minor Comment Addition `packages/renderless/src/grid/utils/common.ts`	Inserted a comment line before pushing recursive results in `getColumnList`; no behavioral change.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Verify the batch3Icons array entries for typos or duplicates.
Confirm both Vue components import batch3Icons correctly and bind it to the template/state.
Check that the new gallery's click handlers and CSS classes match the existing gallery to avoid visual or interaction inconsistencies.
Quick lint/format check for the modified utility and markdown files.

Poem

🐰
I found a batch, a shiny three,
More icons hopping merrily.
Two galleries now leap and play,
Sprinkling pixels on display.
A little comment nods, "hooray!" ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix(icons): add the third batch of icon-saas icons' accurately describes the main change—adding batch3Icons with a complete set of icon-saas icons across three files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7d9bfe3 and ae656f1.

📒 Files selected for processing (3)

examples/sites/demos/mobile-first/app/tree-select/webdoc/tree-select.cn.md (0 hunks)
examples/sites/demos/mobile-first/app/tree-select/webdoc/tree-select.en.md (0 hunks)
packages/renderless/src/grid/utils/common.ts (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (2)

examples/sites/demos/pc/app/icon/advance-usage.vue (1)

53-74: Second icon gallery for batch3Icons mirrors existing behavior

The new <hr /> plus second .svgs-wrapper correctly reuses the same filter and click‑to‑copy behavior for batch3Icons, so UX stays consistent across both batches.

If you expect more batches later, consider extracting this repeated wrapper into a small reusable icon-grid component that takes the icon list as a prop.

examples/sites/demos/pc/app/icon/advance-usage-composition-api.vue (1)

53-74: Composition API gallery for batch3Icons matches the first gallery

The added block renders batch3Icons with the same visibility filter and click handler as advanceIcons, so behavior stays aligned between the two sections.

Same as in the Options API demo, if more batches are added in future, you could factor this markup into a small reusable icon-grid component to reduce duplication.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 01103de and 7d9bfe3.

⛔ Files ignored due to path filters (297)

packages/theme-saas/src/svgs-raw/IconAbnormalCheckIn.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconAbnormalCheckInFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconAcceptance.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconAcceptanceFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconActivation.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconActivationFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconAdministrator.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconAdministratorFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconAgendaView.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconAgendaViewFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconAnalyse.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconAnalyseFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconApproval.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconApprovalFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconAreaChart.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconAreaChartFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconArrowDown.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconArrowDownFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconArrowLeft.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconArrowLeftFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconArrowRight.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconArrowRightFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconArrowUp.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconArrowUpFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconAscending.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconAscendingFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconAskForLeave.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconAskForLeaveFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconAssociation.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconAssociationFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconAttachment.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconAttachmentFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconAudio.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconAudioFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconAudit.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconAuditFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconAutomaticAssessment.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconAutomaticAssessmentFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconBank.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconBankFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconBarChart.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconBarChartFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconBatchFill.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconBatchFillFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconBefilter.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconBefilterFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconBoat.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconBoatFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCalculator.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCalculatorFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCalendar.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCalendarFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCancellationApplication.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCancellationApplicationFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCardModeline.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCardModelineFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCheck.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCheckFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCheckOut.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCheckOutFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCheckProperties.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCheckPropertiesFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCheckedLinear.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCheckedLinearFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconChevronDown.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconChevronDownFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconChevronLeft.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconChevronLeftFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconChevronRight.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconChevronRightFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconChevronUp.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconChevronUpFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconClearFilter.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconClearFilterFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconClockWork.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconClockWorkFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconClose.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCloseCircle.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCloseCircleFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCloseFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCloseSquare.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCloseSquareFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCloudDownload.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCloudDownloadFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCoin.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCoinFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCommission.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCommissionFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCompany.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCompanyFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconComputingJob.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconComputingJobFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconConfirmPayrollProfile.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconConfirmPayrollProfileFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconConmentRefresh.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconConmentRefreshFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconConnectSquare.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconConnectSquareFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCopy.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCopyFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCourse.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCourseFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCrop.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCropFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCrossOrganizationWarehousingList.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCrossOrganizationWarehousingListFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCueL.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCueLFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCurrency.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCurrencyFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCustom.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCustomFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCustomSclearance.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCustomSclearanceFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCustomerService.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCustomerServiceFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCustomsClearanceForm.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCustomsClearanceFormFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCustomsDeclaration.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCustomsDeclarationFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCustomsDeclarationList.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconCustomsDeclarationListFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDailyVisits.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDailyVisitsFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDefault.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDefaultFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDefinedFiltration.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDefinedFiltrationFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDefinitionOfProcessRoles.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDefinitionOfProcessRolesFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDelegatedProcessing.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDelegatedProcessingFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDeletePage.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDeletePageFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDeleted.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDeletedFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDeltaDownO.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDeltaDownOFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDeltaLeftO.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDeltaLeftOFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDeltaRightO.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDeltaRightOFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDeltaUpO.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDeltaUpOFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDemandOrderList.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDemandOrderListFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDescending.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDescendingFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDetailedList.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDetailedListFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDetailsPage.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDetailsPageFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDialog.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDialogFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDigitalassistant.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDigitalassistantFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDisallowance.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDisallowanceFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDotChart.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDotChartFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDotIpv4.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDotIpv4Filled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDoubleLeft.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDoubleLeftFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDoubleRight.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDoubleRightFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDownload.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDownloadCloud.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDownloadCloudFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDownloadFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDrawFlowchart.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconDrawFlowchartFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEarthLined.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEarthLinedFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEdit.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorAlignCenter.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorAlignCenterFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorAlignLeft.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorAlignLeftFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorAlignRight.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorAlignRightFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorBold.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorBoldFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorCode.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorCodeFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorDeleteline.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorDeletelineFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorEraser.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorEraserFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorItalic.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorItalicFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorLeftBorder.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorLeftBorderFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorListDot.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorListDotFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorListNum.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorListNumFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorMenuLeft.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorMenuLeftFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorMenuRight.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorMenuRightFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorQuote.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorQuoteFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorRedo.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorRedoFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorRightBorder.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorRightBorderFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorSub.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorSubFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorSubtitle.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorSubtitleFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorSuper.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorSuperFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorTable.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorTableFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorTextcolor.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorTextcolorFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorTitle.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorTitleFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorUnderline.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorUnderlineFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorUndo.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorUndoFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorVideo.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEditorVideoFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEllipsis.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEllipsisFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEmailAdd.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEmailAddFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEmailCircle.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEmailCircleFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEmployeeInformation.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEmployeeInformationFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEnd.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEndFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEngineWorkflow.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEngineWorkflowFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEquipment.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEquipmentFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEspaceAuto.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEspaceAutoFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconExcelType.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconExcelTypeFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconException.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconExceptionFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconExchangerate.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconExchangerateFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconExecutionPhase.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconExecutionPhaseFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconExhibitionForum.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconExhibitionForumFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconExport.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconExportFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconExpressSearch.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconExpressSearchFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEyeclose.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEyecloseFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEyeopen.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconEyeopenFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconFastCode.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconFastCodeFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconFemale.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconFemaleFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconFile.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconFileCloudupload.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconFileClouduploadFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconFileExcel.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconFileExcelFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconFileFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconFileType.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconFileTypeFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconFilesCircle.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconFilesCircleFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconFiletext.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconFiletextFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconFileupload.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconFileuploadFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconFiltered.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconFilteredFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconFlag.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconFlagFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconFolderClosed.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconFolderClosedFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconFreezeLeft.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconFreezeLeftFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconFreezeRight.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconFreezeRightFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconFrownO.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconFrownOFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconFullscreen.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconFullscreenFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconFullscreenLeft.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconFullscreenLeftFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconGeneralAi.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconGeneralAiFilled.svg is excluded by !**/*.svg
packages/theme-saas/src/svgs-raw/IconGeneralPageIndigo.svg is excluded by !**/*.svg

📒 Files selected for processing (3)

examples/sites/demos/pc/app/icon/advance-icons.js (1 hunks)
examples/sites/demos/pc/app/icon/advance-usage-composition-api.vue (1 hunks)
examples/sites/demos/pc/app/icon/advance-usage.vue (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: PR E2E Test (pnpm test:e2e3)

🔇 Additional comments (3)

examples/sites/demos/pc/app/icon/advance-icons.js (1)

288-412: Verify icon names added in batch3Icons

The new batch3Icons export is structurally consistent with advanceIcons, and wiring it into the demos should work as expected. To avoid silent missing icons, it’s worth quickly confirming that every string matches a real entry on Svgs—a few like IconInventoryLlist, IconPnventoryDiscrepancyAdjustmentList, IconCustomSclearance, IconPeography, IconPirplane look like they might contain typos.

examples/sites/demos/pc/app/icon/advance-usage.vue (1)

90-107: Import and data wiring for batch3Icons is consistent

Importing batch3Icons alongside advanceIcons and exposing it via data() keeps the Options API component consistent with the existing pattern and correctly backs the new gallery.

examples/sites/demos/pc/app/icon/advance-usage-composition-api.vue (1)

81-81: batch3Icons import is correctly exposed to the template

Adding batch3Icons to the named import works cleanly with <script setup>—the template can use both advanceIcons and batch3Icons without additional boilerplate.

…-saas3

shenjunjian added 7 commits December 5, 2025 11:01

fix(icons): remove icon-saas old rawIcons

b869196

fix(icons): add icon-saas batch3

de23000

fix(icons): copy raw icons

1e49f82

fix(icons): add batch3 icons demo

c9d1d41

fix(icons): build batch3 icons

73ade27

fix(icons): add hr to divider two icons

3748520

fix(icons): update batch3 icon-saas icons

7d9bfe3

github-actions bot added the bug Something isn't working label Dec 9, 2025

coderabbitai bot reviewed Dec 9, 2025

View reviewed changes

shenjunjian added 2 commits December 11, 2025 17:29

Merge branch 'dev' of github.com:opentiny/tiny-vue into shen/add-icon…

4b48089

…-saas3

fix(icons): remove fill=none for batch3 icons

ae656f1

zzcr merged commit b56b5fb into dev Dec 11, 2025
4 of 5 checks passed

zzcr deleted the shen/add-icon-saas3 branch December 11, 2025 09:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(icons): add the third batch of icon-saas icons. #3889

fix(icons): add the third batch of icon-saas icons. #3889

shenjunjian commented Dec 9, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Dec 9, 2025 •

edited

Loading

Review failed

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix(icons): add the third batch of icon-saas icons. #3889

fix(icons): add the third batch of icon-saas icons. #3889

Conversation

shenjunjian commented Dec 9, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Poem

Pre-merge checks and finishing touches

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

shenjunjian commented Dec 9, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 9, 2025 •

edited

Loading