Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rich-text-editor): add row height and merge h1-h6 and pargraph #414

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

Caesar-ch
Copy link
Collaborator

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

add row height and merge h1-h6 and pargraph

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Member

@kagol kagol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个应该叫行高line-height,不叫段落paragraph

@kagol kagol added the enhancement New feature or request (功能增强) label Aug 22, 2023
@kagol
Copy link
Member

kagol commented Aug 22, 2023

可以在pr描述中贴一张效果图
@Caesar-ch

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


You can post a rendering in the PR description
@Caesar-ch

@kagol kagol merged commit f3414a3 into opentiny:dev Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request (功能增强)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants