Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 tiny-vue failed to start, adding missing quotes at the end of the string #488

Merged
merged 1 commit into from
Sep 16, 2023
Merged

Conversation

allenli178
Copy link
Contributor

PR

image

fork 的 tiny-vue 启动失败,发现文档部分有字符串缺失末尾引号。
已经添加,可以正常启动。

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kagol kagol added the bug Something isn't working label Sep 16, 2023
Copy link
Member

@kagol kagol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! I'm just coming to fix this problem.

@kagol kagol merged commit 3c3c433 into opentiny:dev Sep 16, 2023
@kagol kagol mentioned this pull request Sep 16, 2023
13 tasks
@kagol
Copy link
Member

kagol commented Oct 25, 2023

@all-contributors please add @allenli178 for code

@allcontributors
Copy link
Contributor

@kagol

I've put up a pull request to add @allenli178! 🎉

@kagol kagol changed the title 🐛 fork tiny-vue 启动失败,添加字符串末尾缺少的引号 🐛 tiny-vue failed to start, adding missing quotes at the end of the string Dec 9, 2023
@kagol
Copy link
Member

kagol commented Jan 8, 2024

@allenli178 恭喜你成为OpenTiny 2023年度开源新星,请添加下OpenTiny小助手微信:opentiny-official,如已添加,请发一条信息给小助手,谢谢!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants