Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVX-5655 Implement dial DTMF digits feature #234

Merged
merged 5 commits into from
Dec 7, 2021

Conversation

superchilled
Copy link
Contributor

@superchilled superchilled commented Oct 31, 2021

Description

Implements the play DTMF feature, either for an individual connection or for all connections in a session. Two methods have been added, one for each of these actions, as well as a helper method for validating DTMF digits.

Motivation and Context

It implements a feature in the SDK which has already been added to the API.

How Has This Been Tested?

Example Output or Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@superchilled superchilled changed the title Adding methods for dialing DTMF digits to client.rb and sip.rb DEVX-5655 Implement dial DTMF digits feature Nov 1, 2021
@superchilled superchilled marked this pull request as ready for review November 3, 2021 13:39
@superchilled superchilled merged commit e89d18f into dev Dec 7, 2021
@superchilled superchilled deleted the devx-5655-play-dtmf-feature branch December 7, 2021 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants