Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVX-5821Fix issue with activesupport #238

Merged
merged 2 commits into from
Jan 21, 2022

Conversation

superchilled
Copy link
Contributor

@superchilled superchilled commented Jan 19, 2022

Description

Fixes an issue with activesupport encountered when activesupport >= 7 is used (versions prior to 7 don't cause this issue).
Issue causes a number of tests to fail for method calls where activesupport/time is required:

Failure/Error: require "active_support/time"

NameError:
  uninitialized constant ActiveSupport::XmlMini::IsolatedExecutionState

Motivation and Context

It fixes an issue with a dependency.

How Has This Been Tested?

Example Output or Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@superchilled superchilled changed the base branch from main to dev January 19, 2022 16:36
@superchilled superchilled merged commit 92fb709 into dev Jan 21, 2022
@superchilled superchilled deleted the devx-5821-fix-activesupport-issue branch January 21, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants