Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVX-6487: Adding support for multiple archives and records feature #248

Merged
merged 7 commits into from
Oct 12, 2022

Conversation

superchilled
Copy link
Contributor

Description

Adds code comments for the multiArchiveTag and multiBroadcastTag properties when creating Archives and Broadcasts.

Motivation and Context

To keep the code comments in line with the actual options specified in the documentation

How Has This Been Tested?

Added tests to ensure that Archives can be created with a multiArchiveTag specified and Broadcasts can be created with a multiBroadcastTag specified.

Copy link
Collaborator

@jeffswartz jeffswartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add multiArchiveTag and multiBroadcastTag as instance attributes of the Archive and Broadcast classes.

@superchilled superchilled merged commit 2438160 into dev Oct 12, 2022
@superchilled superchilled deleted the devx-6487-multiple-archives-and-records branch October 12, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants