Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVX-6493: Add Experience Composer functionality #249

Merged
merged 10 commits into from
Oct 12, 2022

Conversation

superchilled
Copy link
Contributor

Description

Implements the Experience Composer render feature.

Motivation and Context

It implements a feature in the SDK which has already been added to the API.

How Has This Been Tested?

Example Output or Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Collaborator

@jeffswartz jeffswartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor edit suggestion. Also, please be sure to rev the version before merging into main.

lib/opentok/renders.rb Outdated Show resolved Hide resolved
Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com>
jeffswartz
jeffswartz previously approved these changes Sep 29, 2022
lib/opentok/render.rb Outdated Show resolved Hide resolved
@superchilled superchilled merged commit 358a54c into dev Oct 12, 2022
@superchilled superchilled deleted the devx-6493-add-experience-composer branch October 12, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants