-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize publisherOptions for HelloWorld sample #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous PR can be found here |
jeffswartz
approved these changes
Jan 6, 2023
Tr00d
added a commit
that referenced
this pull request
Mar 9, 2023
* Correction to docs for automatic archiving * Fixes NullReferenceException in CreateSession (#114) * Better handle WebExceptions that don't have a Response and send a customized exception on WebExceptionStatus.SendFailure errors (usually from TLS errors). Fixes #108. * Adding extra instructions regarding TLS to readme, adding new exception handling if TLS is incorrect * removing erroneously added whitespace * list archive by session id, better exception handling for validateSessionid * removing extra whitespace from tests * cleaning up other whitespace issues * passing inner exception to OpenTokException * Fixing comments, removing redundant fields * adding custom layout for archiving * fixing spacing issue, adding javadocs to StartArchive for layout * revving to 3.4 * adding extra Archive Test * Adding non-custom with stylesheet case * adding contract annotations to ArchiveLayout to prevent invalid serialization of the stylesheet for non-custom layouts * bringing balance to the force * Dropping core 3.0 tests * moving back to newer container * removing .net core 2.x runs * Silenced warnings in the test project. * empty Statement Redundancy Fix * Spell Fix * Spell Fix * Spell Fix | GetPartnerIdFromSessionId Spell Fix | GetPartnerIdFromSessionId method's Property * moving dotnet version * specifying test framework * Changed Javadoc comments to XML comments. * Replace <see href with <a href. * Added additional comments. * Revving to 3.5.0 * automatic release on new GitHub release * adding OUTPUT_PATH * fixing Windows CI issue * updating nexmo/github-actions branch to main * screenshare layout * more tests * Adding SetArchiveLayout, updating unit tests * moving null ignore to data structure * fixing error message * fixing screenshareType * revving to 3.6.0 * Removing travis config * Removing travis, fixing GitHub Actions definitions and adding package settings in project file (#164) * Docs corrections (#161) Co-authored-by: Stephen Lorello <42971704+slorello89@users.noreply.github.com> Co-authored-by: slorello89 <slorello89@gmail.com> Co-authored-by: Dirk Lemstra <dirk@lemstra.org> Co-authored-by: onpoc <gupta.pradeep506@gmail.com> Co-authored-by: Matt Hunt <mattlethargic@gmail.com> Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> * Implementing Dial method for initiating a SIP call (#166) * Adding Dial method, test fails * Adding dial async and tests * Adding session validation * Removing key from appsettings * Adding valid session id to tests * Docs edits for Dial API ... and other minor docs corrections Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> * Rev the version to 3.7.0 * Adding Force and Disable Mute (#167) * Adding Force and Disable Mute * Docs edits for the Force Mute API enhancements * Fixing PlayDTMF methods that had wrong URL Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> Co-authored-by: matt-lethargic <matt-lethargic@gmail.com> * Docs edits for v3.7.0 (#169) * Changing version number (#170) * Docs corrections * Selective adding of streams for archive and broadcast (#174) * Selective adding of streams for archive and broadcast * Minor docs edits for StreamMode additions * bumping version to 3.8.0 * Another version bump Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> * Devx 5778 (#179) * Moving tests * refactoring test base * CreateSession async * Start Archive Async * Fixing dial issue * Removing duplicate version tags in proj file and updating README with Async methods Co-authored-by: matt-lethargic <matt-lethargic@gmail.com> * Minor docs typo correction (#181) * Adding GetArchive and DeleteArchive async methods (#182) * Adding GetArchive and DeleteArchive async methods * Adding readme info and adding methods to Archieve object * DVR and LowLatency changes added (#183) * DVR and LowLatency changes added * Update OpenTok/OpenTok.cs Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> * Fixing comments for PR * Adding Broadcast settings summary * Docs edits for BroadcastHlsSettings and related content. Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> * Devx 5971 - StopArchive and ListArchive Async Methods (#184) * Adding Stop Archive and ListArchive async methods * Minor docs edit Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> * Adding StopBroadcast and GetBroadcast methods (#186) * Adding GetStream and ListStreams async methods (#187) * Adding SetBroadcastLayout and SetArchiveLayout async methods (#188) * Adding SetBroadcastLayout and SetArchiveLayout async methods * Minor docs edit * Fixing merge conflict issues Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> Co-authored-by: matt-lethargic <matt-lethargic@gmail.com> * Fixing some merge issues * Devx 5946 (#191) * added SetStreamListsAsync * SignalAsync methods added * Adding StartBroadcast async methods Refactoring tests * Devx 5915 - Update .NET Server SDK for 1080p Archive/Broadcast (#207) * Add all available resolutions for archiving in README.md * Add all available resolutions on XML documentation for Broadcast.cs * Add all available resolutions on Broadcasting sample app * Upgrade System.Net.Http to 4.3.2 as suggested by Whitesource * Upgrade System.Net.Http to 4.3.4 as suggested by Whitesource * Initialize publisherOptions for HelloWorld sample (#209) * DEVX-6497 - Add Experience Composer to the OpenTok .NET Server SDK (#210) * Create object and implement parsing for StartRender operation * Fix wrong allowed resolution * Implement request creation with various values, including optional ones * Fix warning for http (test value) * Kill last mutants for threshold values * Implement POST call to start a rendering * Make StartRenderResponse immutable * Implement StopRenderAsync * Implement ListRendersRequest parsing * Kill mutants for http headers * Fix type in ListRenders * Implement ListRendersAsync * Implement GetRenderAsync * Kill mutants on StartRenderRequest, make all responses as struct for value equality * Fix request formatting issue - last test round * Add missing Xml comments * Amend TODO comments * Experience Composer Render API docs edits * Make ScreenResolutionConverter private * Rename ScreenResolution into RenderResolution * Remove StatusCallbackUrl * Make StreamName optional, expect a PublisherProperties when creating a StartRenderRequest Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> * Devx 6491 - Update.NET Server SDK for Multiple Archives and Records (#208) * Add multiArchiveTag on Archive.cs * Fix wrong assertion in ArchiveTests.cs * Add multiBroadcastTag on Broadcast.cs * Add missing Xml documentation for new parameters * Upgrade System.Net.Http to 4.3.4 as suggested by Whitesource * Docs edits for simultaneous archive/broadcast features * Fix conflict with MultiBroadcastTag Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> * Rev version to 3.9.0 (#212) * DEVX-5909 - Add Audio Streamer to OpenTok .Net SDK (#211) * Implement ConnectRequest parsing * Implement StopAudioStreamer * Renaming elements for AudioConnector, fix xml documentations, flatten namespaces Rename AudioStreamer by AudioConnector Rename ConnectRequest by AudioConnectorStartRequest Rename ConnectResponse by AudioConnector * Update README with AudioConnector snippet * Fix merge conflicts * README edits * Minor docs edit --------- Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> --------- Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> Co-authored-by: Paul Ardeleanu <paul.ardeleanu@vonage.com> Co-authored-by: Patrick Childers <patrick@aliihealthcare.com> Co-authored-by: Stephen Lorello <42971704+slorello89@users.noreply.github.com> Co-authored-by: slorello89 <slorello89@gmail.com> Co-authored-by: Dirk Lemstra <dirk@lemstra.org> Co-authored-by: onpoc <gupta.pradeep506@gmail.com> Co-authored-by: Matt Hunt <mattlethargic@gmail.com> Co-authored-by: matt-lethargic <matt-lethargic@gmail.com>
Tr00d
added a commit
that referenced
this pull request
May 10, 2023
* Correction to docs for automatic archiving * Fixes NullReferenceException in CreateSession (#114) * Better handle WebExceptions that don't have a Response and send a customized exception on WebExceptionStatus.SendFailure errors (usually from TLS errors). Fixes #108. * Adding extra instructions regarding TLS to readme, adding new exception handling if TLS is incorrect * removing erroneously added whitespace * list archive by session id, better exception handling for validateSessionid * removing extra whitespace from tests * cleaning up other whitespace issues * passing inner exception to OpenTokException * Fixing comments, removing redundant fields * adding custom layout for archiving * fixing spacing issue, adding javadocs to StartArchive for layout * revving to 3.4 * adding extra Archive Test * Adding non-custom with stylesheet case * adding contract annotations to ArchiveLayout to prevent invalid serialization of the stylesheet for non-custom layouts * bringing balance to the force * Dropping core 3.0 tests * moving back to newer container * removing .net core 2.x runs * Silenced warnings in the test project. * empty Statement Redundancy Fix * Spell Fix * Spell Fix * Spell Fix | GetPartnerIdFromSessionId Spell Fix | GetPartnerIdFromSessionId method's Property * moving dotnet version * specifying test framework * Changed Javadoc comments to XML comments. * Replace <see href with <a href. * Added additional comments. * Revving to 3.5.0 * automatic release on new GitHub release * adding OUTPUT_PATH * fixing Windows CI issue * updating nexmo/github-actions branch to main * screenshare layout * more tests * Adding SetArchiveLayout, updating unit tests * moving null ignore to data structure * fixing error message * fixing screenshareType * revving to 3.6.0 * Removing travis config * Removing travis, fixing GitHub Actions definitions and adding package settings in project file (#164) * Docs corrections (#161) Co-authored-by: Stephen Lorello <42971704+slorello89@users.noreply.github.com> Co-authored-by: slorello89 <slorello89@gmail.com> Co-authored-by: Dirk Lemstra <dirk@lemstra.org> Co-authored-by: onpoc <gupta.pradeep506@gmail.com> Co-authored-by: Matt Hunt <mattlethargic@gmail.com> Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> * Implementing Dial method for initiating a SIP call (#166) * Adding Dial method, test fails * Adding dial async and tests * Adding session validation * Removing key from appsettings * Adding valid session id to tests * Docs edits for Dial API ... and other minor docs corrections Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> * Rev the version to 3.7.0 * Adding Force and Disable Mute (#167) * Adding Force and Disable Mute * Docs edits for the Force Mute API enhancements * Fixing PlayDTMF methods that had wrong URL Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> Co-authored-by: matt-lethargic <matt-lethargic@gmail.com> * Docs edits for v3.7.0 (#169) * Changing version number (#170) * Docs corrections * Selective adding of streams for archive and broadcast (#174) * Selective adding of streams for archive and broadcast * Minor docs edits for StreamMode additions * bumping version to 3.8.0 * Another version bump Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> * Devx 5778 (#179) * Moving tests * refactoring test base * CreateSession async * Start Archive Async * Fixing dial issue * Removing duplicate version tags in proj file and updating README with Async methods Co-authored-by: matt-lethargic <matt-lethargic@gmail.com> * Minor docs typo correction (#181) * Adding GetArchive and DeleteArchive async methods (#182) * Adding GetArchive and DeleteArchive async methods * Adding readme info and adding methods to Archieve object * DVR and LowLatency changes added (#183) * DVR and LowLatency changes added * Update OpenTok/OpenTok.cs Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> * Fixing comments for PR * Adding Broadcast settings summary * Docs edits for BroadcastHlsSettings and related content. Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> * Devx 5971 - StopArchive and ListArchive Async Methods (#184) * Adding Stop Archive and ListArchive async methods * Minor docs edit Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> * Adding StopBroadcast and GetBroadcast methods (#186) * Adding GetStream and ListStreams async methods (#187) * Adding SetBroadcastLayout and SetArchiveLayout async methods (#188) * Adding SetBroadcastLayout and SetArchiveLayout async methods * Minor docs edit * Fixing merge conflict issues Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> Co-authored-by: matt-lethargic <matt-lethargic@gmail.com> * Fixing some merge issues * Devx 5946 (#191) * added SetStreamListsAsync * SignalAsync methods added * Adding StartBroadcast async methods Refactoring tests * Devx 5915 - Update .NET Server SDK for 1080p Archive/Broadcast (#207) * Add all available resolutions for archiving in README.md * Add all available resolutions on XML documentation for Broadcast.cs * Add all available resolutions on Broadcasting sample app * Upgrade System.Net.Http to 4.3.2 as suggested by Whitesource * Upgrade System.Net.Http to 4.3.4 as suggested by Whitesource * Initialize publisherOptions for HelloWorld sample (#209) * DEVX-6497 - Add Experience Composer to the OpenTok .NET Server SDK (#210) * Create object and implement parsing for StartRender operation * Fix wrong allowed resolution * Implement request creation with various values, including optional ones * Fix warning for http (test value) * Kill last mutants for threshold values * Implement POST call to start a rendering * Make StartRenderResponse immutable * Implement StopRenderAsync * Implement ListRendersRequest parsing * Kill mutants for http headers * Fix type in ListRenders * Implement ListRendersAsync * Implement GetRenderAsync * Kill mutants on StartRenderRequest, make all responses as struct for value equality * Fix request formatting issue - last test round * Add missing Xml comments * Amend TODO comments * Experience Composer Render API docs edits * Make ScreenResolutionConverter private * Rename ScreenResolution into RenderResolution * Remove StatusCallbackUrl * Make StreamName optional, expect a PublisherProperties when creating a StartRenderRequest Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> * Devx 6491 - Update.NET Server SDK for Multiple Archives and Records (#208) * Add multiArchiveTag on Archive.cs * Fix wrong assertion in ArchiveTests.cs * Add multiBroadcastTag on Broadcast.cs * Add missing Xml documentation for new parameters * Upgrade System.Net.Http to 4.3.4 as suggested by Whitesource * Docs edits for simultaneous archive/broadcast features * Fix conflict with MultiBroadcastTag Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> * Rev version to 3.9.0 (#212) * DEVX-5909 - Add Audio Streamer to OpenTok .Net SDK (#211) * Implement ConnectRequest parsing * Implement StopAudioStreamer * Renaming elements for AudioConnector, fix xml documentations, flatten namespaces Rename AudioStreamer by AudioConnector Rename ConnectRequest by AudioConnectorStartRequest Rename ConnectResponse by AudioConnector * Update README with AudioConnector snippet * Fix merge conflicts * README edits * Minor docs edit --------- Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> * [DEVX-6811] Expose E2EE parameter on Session creation (#218) * Add optional parameter to enable end-to-end encryption when creating a session * Minor docs edits --------- Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> * fix: audio connector (#224) * Add test for serialization * Change expectation in other test --------- Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> Co-authored-by: Paul Ardeleanu <paul.ardeleanu@vonage.com> Co-authored-by: Patrick Childers <patrick@aliihealthcare.com> Co-authored-by: Stephen Lorello <42971704+slorello89@users.noreply.github.com> Co-authored-by: slorello89 <slorello89@gmail.com> Co-authored-by: Dirk Lemstra <dirk@lemstra.org> Co-authored-by: onpoc <gupta.pradeep506@gmail.com> Co-authored-by: Matt Hunt <mattlethargic@gmail.com> Co-authored-by: matt-lethargic <matt-lethargic@gmail.com>
Tr00d
added a commit
that referenced
this pull request
Jun 22, 2023
* Correction to docs for automatic archiving * Fixes NullReferenceException in CreateSession (#114) * Better handle WebExceptions that don't have a Response and send a customized exception on WebExceptionStatus.SendFailure errors (usually from TLS errors). Fixes #108. * Adding extra instructions regarding TLS to readme, adding new exception handling if TLS is incorrect * removing erroneously added whitespace * list archive by session id, better exception handling for validateSessionid * removing extra whitespace from tests * cleaning up other whitespace issues * passing inner exception to OpenTokException * Fixing comments, removing redundant fields * adding custom layout for archiving * fixing spacing issue, adding javadocs to StartArchive for layout * revving to 3.4 * adding extra Archive Test * Adding non-custom with stylesheet case * adding contract annotations to ArchiveLayout to prevent invalid serialization of the stylesheet for non-custom layouts * bringing balance to the force * Dropping core 3.0 tests * moving back to newer container * removing .net core 2.x runs * Silenced warnings in the test project. * empty Statement Redundancy Fix * Spell Fix * Spell Fix * Spell Fix | GetPartnerIdFromSessionId Spell Fix | GetPartnerIdFromSessionId method's Property * moving dotnet version * specifying test framework * Changed Javadoc comments to XML comments. * Replace <see href with <a href. * Added additional comments. * Revving to 3.5.0 * automatic release on new GitHub release * adding OUTPUT_PATH * fixing Windows CI issue * updating nexmo/github-actions branch to main * screenshare layout * more tests * Adding SetArchiveLayout, updating unit tests * moving null ignore to data structure * fixing error message * fixing screenshareType * revving to 3.6.0 * Removing travis config * Removing travis, fixing GitHub Actions definitions and adding package settings in project file (#164) * Docs corrections (#161) Co-authored-by: Stephen Lorello <42971704+slorello89@users.noreply.github.com> Co-authored-by: slorello89 <slorello89@gmail.com> Co-authored-by: Dirk Lemstra <dirk@lemstra.org> Co-authored-by: onpoc <gupta.pradeep506@gmail.com> Co-authored-by: Matt Hunt <mattlethargic@gmail.com> Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> * Implementing Dial method for initiating a SIP call (#166) * Adding Dial method, test fails * Adding dial async and tests * Adding session validation * Removing key from appsettings * Adding valid session id to tests * Docs edits for Dial API ... and other minor docs corrections Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> * Rev the version to 3.7.0 * Adding Force and Disable Mute (#167) * Adding Force and Disable Mute * Docs edits for the Force Mute API enhancements * Fixing PlayDTMF methods that had wrong URL Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> Co-authored-by: matt-lethargic <matt-lethargic@gmail.com> * Docs edits for v3.7.0 (#169) * Changing version number (#170) * Docs corrections * Selective adding of streams for archive and broadcast (#174) * Selective adding of streams for archive and broadcast * Minor docs edits for StreamMode additions * bumping version to 3.8.0 * Another version bump Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> * Devx 5778 (#179) * Moving tests * refactoring test base * CreateSession async * Start Archive Async * Fixing dial issue * Removing duplicate version tags in proj file and updating README with Async methods Co-authored-by: matt-lethargic <matt-lethargic@gmail.com> * Minor docs typo correction (#181) * Adding GetArchive and DeleteArchive async methods (#182) * Adding GetArchive and DeleteArchive async methods * Adding readme info and adding methods to Archieve object * DVR and LowLatency changes added (#183) * DVR and LowLatency changes added * Update OpenTok/OpenTok.cs Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> * Fixing comments for PR * Adding Broadcast settings summary * Docs edits for BroadcastHlsSettings and related content. Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> * Devx 5971 - StopArchive and ListArchive Async Methods (#184) * Adding Stop Archive and ListArchive async methods * Minor docs edit Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> * Adding StopBroadcast and GetBroadcast methods (#186) * Adding GetStream and ListStreams async methods (#187) * Adding SetBroadcastLayout and SetArchiveLayout async methods (#188) * Adding SetBroadcastLayout and SetArchiveLayout async methods * Minor docs edit * Fixing merge conflict issues Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> Co-authored-by: matt-lethargic <matt-lethargic@gmail.com> * Fixing some merge issues * Devx 5946 (#191) * added SetStreamListsAsync * SignalAsync methods added * Adding StartBroadcast async methods Refactoring tests * Devx 5915 - Update .NET Server SDK for 1080p Archive/Broadcast (#207) * Add all available resolutions for archiving in README.md * Add all available resolutions on XML documentation for Broadcast.cs * Add all available resolutions on Broadcasting sample app * Upgrade System.Net.Http to 4.3.2 as suggested by Whitesource * Upgrade System.Net.Http to 4.3.4 as suggested by Whitesource * Initialize publisherOptions for HelloWorld sample (#209) * DEVX-6497 - Add Experience Composer to the OpenTok .NET Server SDK (#210) * Create object and implement parsing for StartRender operation * Fix wrong allowed resolution * Implement request creation with various values, including optional ones * Fix warning for http (test value) * Kill last mutants for threshold values * Implement POST call to start a rendering * Make StartRenderResponse immutable * Implement StopRenderAsync * Implement ListRendersRequest parsing * Kill mutants for http headers * Fix type in ListRenders * Implement ListRendersAsync * Implement GetRenderAsync * Kill mutants on StartRenderRequest, make all responses as struct for value equality * Fix request formatting issue - last test round * Add missing Xml comments * Amend TODO comments * Experience Composer Render API docs edits * Make ScreenResolutionConverter private * Rename ScreenResolution into RenderResolution * Remove StatusCallbackUrl * Make StreamName optional, expect a PublisherProperties when creating a StartRenderRequest Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> * Devx 6491 - Update.NET Server SDK for Multiple Archives and Records (#208) * Add multiArchiveTag on Archive.cs * Fix wrong assertion in ArchiveTests.cs * Add multiBroadcastTag on Broadcast.cs * Add missing Xml documentation for new parameters * Upgrade System.Net.Http to 4.3.4 as suggested by Whitesource * Docs edits for simultaneous archive/broadcast features * Fix conflict with MultiBroadcastTag Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> * Rev version to 3.9.0 (#212) * DEVX-5909 - Add Audio Streamer to OpenTok .Net SDK (#211) * Implement ConnectRequest parsing * Implement StopAudioStreamer * Renaming elements for AudioConnector, fix xml documentations, flatten namespaces Rename AudioStreamer by AudioConnector Rename ConnectRequest by AudioConnectorStartRequest Rename ConnectResponse by AudioConnector * Update README with AudioConnector snippet * Fix merge conflicts * README edits * Minor docs edit --------- Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> * [DEVX-6811] Expose E2EE parameter on Session creation (#218) * Add optional parameter to enable end-to-end encryption when creating a session * Minor docs edits --------- Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> * fix: audio connector (#224) * Add test for serialization * Change expectation in other test * Implement custom user-agent value (#219) * Allow broadcast to compose without audio or video. (#225) * Implement AutoArchive parameters on CreateSession (#227) --------- Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com> Co-authored-by: Paul Ardeleanu <paul.ardeleanu@vonage.com> Co-authored-by: Patrick Childers <patrick@aliihealthcare.com> Co-authored-by: Stephen Lorello <42971704+slorello89@users.noreply.github.com> Co-authored-by: slorello89 <slorello89@gmail.com> Co-authored-by: Dirk Lemstra <dirk@lemstra.org> Co-authored-by: onpoc <gupta.pradeep506@gmail.com> Co-authored-by: Matt Hunt <mattlethargic@gmail.com> Co-authored-by: matt-lethargic <matt-lethargic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HelloWorld sample app was not working as 'publisherOptions' was never instantiated.
I used values from other sample apps to initialize it.