Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: post encoding for client #318

Merged
merged 1 commit into from
Jan 2, 2024
Merged

fix: post encoding for client #318

merged 1 commit into from
Jan 2, 2024

Conversation

manchuck
Copy link
Contributor

What is this PR doing?

How should this be manually tested?

What are the relevant tickets?

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #318 (bd57982) into main (111be34) will increase coverage by 18.0%.
Report is 5 commits behind head on main.
The diff coverage is 79.5%.

Additional details and impacted files
Files Coverage Δ
spec/opentok_spec.js 100.0% <100.0%> (ø)
lib/moderation.js 93.1% <88.8%> (-2.6%) ⬇️
lib/signaling.js 88.8% <90.9%> (ø)
lib/opentok.js 76.4% <28.5%> (-0.4%) ⬇️
lib/client.js 93.6% <90.7%> (+14.7%) ⬆️
lib/render.js 19.6% <12.5%> (-2.0%) ⬇️
lib/callbacks.js 74.6% <77.1%> (+1.6%) ⬆️
lib/archiving.js 75.4% <77.2%> (+66.8%) ⬆️

... and 1 file with indirect coverage changes

Copy link

@conshus conshus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. You answered my questions. Looks good to me.

@manchuck manchuck merged commit 4778c07 into main Jan 2, 2024
14 checks passed
@manchuck manchuck deleted the fix-encoding branch January 2, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants