-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add podspec for autolinking support in RN 0.6x #358
Conversation
Huge +1 for this PR! Thanks @snobear, hope it gets merged soon |
Eh this podspec isn't sufficient to get opentok-react-native working with RN 0.6x. With a fresh project using
I've tried a thousand different things, but not exactly sure what else we need to tweak in this library to get it working with RN 0.6. Steps to Reproduce
From here its a bunch of header file not found errors. I've tried tweaking the I can move this to an issue instead of a PR, but wanted to get a discussion going. Let me know if anyone has any troubleshooting ideas. |
OK fixed the header issues by adding the required dependencies to the podspec file:
Now getting the following:
Gettin there! Tried adding JavascriptCore.Framework` under the target's Build Phases > Link Binary With Libraries per other suggestions but no luck on that. |
Hello @snobear, I suspect it is because you are only adding the .h and .m files in the src_files import. Maybe you should add the .swift files there too? |
Hello, @snobear good news, I confirmed that using s.source_files = "ios/**/*.{h,m,swift}" resolves the issue you mentioned! However, this seems to lead to a new problem, where the two interfaces: @interface OTPublisher
@interface OTSubscriber are defined twice: One in the OpenTok.framework, and one in the opentok-react-native library. One of these headers should be made private. @snobear or anyone, any ideas? |
Nice, thanks for working through this with me @yasithmilinda. Adding swift then rerunning I get the duplicate header issue now as you mentioned...I'll try the changes in your PR and then do some further testing of actual RN code to make sure all is looking good. |
Remove duplicate header
Hey, can we please get this merged? |
All looks good on iOS after merging #361 to fix the duplicate headers. However, this has not been tested on RN <0.60, which @yasithmilinda will do to make sure those duplicate header removals don’t have a negative effect on older versions. |
@yasithmilinda awesome! This PR should be good to merge into master then IMO. |
Awesome! Thank you @yasithmilinda! :) |
you're welcome @th317erd! |
Hello folks, can we get this feature merged? |
Hi guys, thank you for the great job here. |
Thank you for the work so far. Are there any updates on this? |
When are you going to release it? |
Need this feature soon as we are not able to test this library on a native device without this feature. Greatly appreciate if the PR is merged. |
Hi @barunprasad, sorry the delay on this. We're currently reviewing this PR. |
@snobear maybe I'm missing a step but I'm getting this after following your steps with RN 0.61 on a fresh project. |
@ggoldens thank you for the response. We are currently on the latest version of RN 0.61.x and we constantly upgrade to the latest version which needs all libraries to move to auto linking (not use react-native link). All our dependencies have auto-linking support. You can say that for this library we can make an exception and do the manual setup. But we wanted to make sure we only add those libraries to our project which does not block us from upgrading our projects in the future. Hence the request to have this feature ready. |
@barunprasad For now you could always do what I am doing for now: Create a |
@snobear were you able to reproduce the error I put above? thanks. |
@ggoldens sorry been tied up. Taking a look now. |
FYI I_was getting a new error:
but fixed by specifying |
@ggoldens I'm able to install the PR with a fresh 0.61.4 RN project. You definitely shouldn't get complaints about React being available, as the podspec has it specified as a dependency. I would double-check that Also try clearing out cache as specified in the simulator, and close any running metro bundler and Xcode instances if they're running before doing a new project. Can some other folks please try installing this w/ a new project per install steps? My system info in case its helpful:
|
I was able to integrate @snobear PR into our project and it's working fine |
Hi all, just checking if we can get two other reviewers to review/merge please? cc @ggoldens @enricop89 |
@snobear, can you point this PR to the branch 0.12.2 please? |
@ggoldens done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add podspec to support autolinking in React Native 0.6x.
Solves issue #332