Update OTSessionManager.java - Fix camera lifecycle #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnx-carlosvogt
changed the title
|
Hi guys, We are using the lib for a while and had this problem. We solved this doing what @cnx-carlosvogt mentioned above. |
jeffswartz
reviewed
Jun 26, 2023
| import android.util.Log; | ||
| import android.widget.FrameLayout; | ||
| import android.view.View; | ||
|
|
||
| import androidx.annotation.Nullable; | ||
|
|
||
| import androidx.annotation.RequiresApi; |
There was a problem hiding this comment.
@cnx-carlosvogt cnx-carlosvogt The PR looks good. Can we delete this line? I don't see it used in the code:
Suggested change
| import androidx.annotation.RequiresApi; |
There was a problem hiding this comment.
Hey, @jeffswartz . I work with @cnx-carlosvogt and he is on vacation now. Yes, we can proceed with this deletion.
There was a problem hiding this comment.
Great. Thanks, @cnx-renansoares. I am merging this in and will create a new version of the library with fix. And thanks again @cnx-carlosvogt for fixing this.
jeffswartz
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing checklist
Bugfix #150
This PR fixes the problem of the camera freezing in certain situations, such as when another application takes control of the camera and when returning to opentok the camera remains frozen, with this correction this no longer occurs.
Solves issue(s)