-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OTSessionManager.java - Fix camera lifecycle #654
Conversation
Hi guys, We are using the lib for a while and had this problem. We solved this doing what @cnx-carlosvogt mentioned above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
import android.util.Log; | ||
import android.widget.FrameLayout; | ||
import android.view.View; | ||
|
||
import androidx.annotation.Nullable; | ||
|
||
import androidx.annotation.RequiresApi; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cnx-carlosvogt cnx-carlosvogt The PR looks good. Can we delete this line? I don't see it used in the code:
import androidx.annotation.RequiresApi; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @jeffswartz . I work with @cnx-carlosvogt and he is on vacation now. Yes, we can proceed with this deletion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Thanks, @cnx-renansoares. I am merging this in and will create a new version of the library with fix. And thanks again @cnx-carlosvogt for fixing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Contributing checklist
Bugfix #150
This PR fixes the problem of the camera freezing in certain situations, such as when another application takes control of the camera and when returning to opentok the camera remains frozen, with this correction this no longer occurs.
Solves issue(s)