-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VIDCS-974: React Native- IOS: App crash #675
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Lef some comments but feel free to disregard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not much to say. I am not familiar with this code, if it fixes the crash... great!
{ | ||
// don't rock the boat. if nothing has changed, don't update anything. | ||
- (CMTime)getTimeStamp { | ||
static mach_timebase_info_data_t time_info; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need a static here? Is the call below particularly slow?
OTScreenCapture
class was updated to replace timer producing crash on start/stop screen share publish.Contributing checklist
Solves issue(s)
VIDCS-974: React Native- IOS: App crash