VIDCS-974: React Native- IOS: App crash #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvalli
requested review from
IGitGotIt,
juliobecerragomez,
sergioturgil-vonage and
goncalocostamendes
goncalocostamendes
approved these changes
Jun 23, 2023
juliobecerragomez
approved these changes
Jun 26, 2023
| { | ||
| // don't rock the boat. if nothing has changed, don't update anything. | ||
| - (CMTime)getTimeStamp { | ||
| static mach_timebase_info_data_t time_info; |
There was a problem hiding this comment.
Why do we need a static here? Is the call below particularly slow?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OTScreenCaptureclass was updated to replace timer producing crash on start/stop screen share publish.Contributing checklist
Solves issue(s)
VIDCS-974: React Native- IOS: App crash