Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix android crash in develop v2.27.5 #753

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

jeffswartz
Copy link
Collaborator

Contributing checklist

  • Code must follow existing styling conventions
  • Added a descriptive commit message
  • Sample apps updated if needed

Solves issue(s)

sendEventMap(this.getReactApplicationContext(), event, streamInfo);
streamInfo.putString("publisherId", publisherId);
sendEventMap(this.getReactApplicationContext(), "publisherStreamCreated", streamInfo);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React Native on Android does now appear to like the sequential calls to emit events over the bridge, so now both the OTSubscriber and OTPublisher JS components will receive the one event. The OTPublisher will filter events based on the publisherId in the event data (not in the event name).

Copy link
Collaborator

@jintgeorge jintgeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just curious where was the crash happening?

Copy link
Collaborator

@marinaserranomontes marinaserranomontes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marinaserranomontes marinaserranomontes merged commit 91abf9d into develop Jun 19, 2024
2 checks passed
@jeffswartz jeffswartz deleted the fix-android-crash-v2.27.5 branch June 20, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants