Merge pull request #4 from pronebird/fix/issue-3

Make sure we do not create DOM element when insertDefaultUI is false
opentok · Mar 16, 2017 · a55595b · a55595b
2 parents 9ee4d18 + a0a50be
commit a55595b
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 5 deletions.
diff --git a/src/OTPublisher.js b/src/OTPublisher.js
@@ -25,12 +25,17 @@ export default class OTPublisher extends Component {
     if (!this.props.session) {
       return;
     }
+
+    let properties = this.props.properties || {};
+    let container;
+
+    if(properties.insertDefaultUI !== false) {
+      container = document.createElement('div');
+      container.setAttribute('class', 'OTPublisherContainer');
+      findDOMNode(this).appendChild(container);
+    }
 
-    let container = document.createElement('div');
-    container.setAttribute('class', 'OTPublisherContainer');
-    findDOMNode(this).appendChild(container);
-
-    let publisher = OT.initPublisher(container, this.props.properties);
+    let publisher = OT.initPublisher(container, properties);
     publisher.on('streamCreated', this.streamCreatedHandler);
 
     if (

diff --git a/test/OTPublisher.spec.js b/test/OTPublisher.spec.js
@@ -50,6 +50,19 @@ describe('OTPublisher', () => {
       ]);
     });
 
+    describe('configuration', () => {
+      beforeEach(() => {
+        session.connection = {};
+      });
+
+      it('should not render the publisher container element when default UI is disabled', () => {
+        const wrapper = mount(<OTPublisher session={session} properties={{ insertDefaultUI: false }} />);
+        const divContainer = wrapper.render().find('div.OTPublisherContainer');
+        expect(divContainer.length).toBe(0);
+      });
+
+    });
+
     describe('connected session', () => {
       let wrapper;