Skip to content
This repository has been archived by the owner on Nov 25, 2022. It is now read-only.

Make sure we do not create DOM element when insertDefaultUI is false #4

Merged
merged 3 commits into from
Mar 16, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/OTPublisher.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,17 @@ export default class OTPublisher extends Component {
if (!this.props.session) {
return;
}

let properties = this.props.properties || {};
let container;

if(properties.insertDefaultUI !== false) {
container = document.createElement('div');
container.setAttribute('class', 'OTPublisherContainer');
findDOMNode(this).appendChild(container);
}

let container = document.createElement('div');
container.setAttribute('class', 'OTPublisherContainer');
findDOMNode(this).appendChild(container);

let publisher = OT.initPublisher(container, this.props.properties);
let publisher = OT.initPublisher(container, properties);
publisher.on('streamCreated', this.streamCreatedHandler);

if (
Expand Down
13 changes: 13 additions & 0 deletions test/OTPublisher.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,19 @@ describe('OTPublisher', () => {
]);
});

describe('configuration', () => {
beforeEach(() => {
session.connection = {};
});

it('should not render the publisher container element when default UI is disabled', () => {
const wrapper = mount(<OTPublisher session={session} properties={{ insertDefaultUI: false }} />);
const divContainer = wrapper.render().find('div.OTPublisherContainer');
expect(divContainer.length).toBe(0);
});

});

describe('connected session', () => {
let wrapper;

Expand Down