Skip to content
This repository has been archived by the owner on Nov 25, 2022. It is now read-only.

Allow React 16 as peer dependency #45

Merged
merged 3 commits into from
Nov 6, 2018
Merged

Allow React 16 as peer dependency #45

merged 3 commits into from
Nov 6, 2018

Conversation

gasi
Copy link
Contributor

@gasi gasi commented Oct 23, 2018

Unless this library has known incompatibilities with React 16.x, could we allow it as an alternate peer dependency besides React 15.x?

@gasi
Copy link
Contributor Author

gasi commented Oct 26, 2018

Polite ping! If opentok-react is known to work on React 16 (our own internal tests seem to confirm), could you please include under peerDependencies? /cc @msach22 @aiham

@msach22
Copy link
Contributor

msach22 commented Nov 5, 2018

@gasi Thanks for the PR. This should work perfectly, I will do a few sanity checks and update you soon 😄

@pandaiolo
Copy link

I don't use all features of opentok-react but everything seem to work well here 👍

@msach22 msach22 changed the base branch from master to dev November 6, 2018 21:35
Copy link
Contributor

@msach22 msach22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@msach22 msach22 merged commit 994d15d into opentok:dev Nov 6, 2018
@gasi gasi deleted the patch-1 branch November 13, 2018 15:26
@gasi
Copy link
Contributor Author

gasi commented Nov 13, 2018

Thanks!

allensarmiento pushed a commit to allensarmiento/opentok-react that referenced this pull request Mar 12, 2020
Allow React 16 as peer dependency
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants