Jasmine test helpers #115
Merged
Jasmine test helpers #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100% (diff: 100%)@@ master #115 diff @@
====================================
Files 66 66
Lines 1339 1339
Methods 155 155
Messages 0 0
Branches 146 146
====================================
Hits 1339 1339
Misses 0 0
Partials 0 0
|
fidian
requested changes
Sep 15, 2016
| @@ -37,6 +37,7 @@ | |||
| "eslint": "^2.10.2", | |||
| "istanbul": "^0.4.2", | |||
| "jasmine-node": "^1.14.5", | |||
| "jasmine-node-helpers": "https://github.com/tests-always-included/jasmine-node-helpers", | |||
There was a problem hiding this comment.
We should wait until the repo is pushed to npm and renamed. After that, this line should simply be
"jasmine-test-helpers": "^1.0.0",
Or whatever the current version is.
There was a problem hiding this comment.
Sounds good. I'll make that change.
|
Looks good to me once we get the package published and can include it. |
|
Approved. Squashing and merging. |
|
The one test is failing because of an issue introduced into Node. nodejs/node#8571 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.