using active span if exists instead of extracting from http headers #74
Conversation
…ts instead of extracting from http headers
There was a problem hiding this comment.
@tmszdmsk thanks! It looks good.
Tests are based on Jetty, so we can use jetty filter to test it. You will have to create a new class which extends AbstractJetty test and then subclass it in every jax-rs provider. Or maybe there is a better way :)
| Format.Builtin.HTTP_HEADERS, | ||
| new ServerHeadersExtractTextMap(requestContext.getHeaders()) | ||
| ); | ||
| if (extractedSpanContext != null) { |
There was a problem hiding this comment.
nit: This if looks redundant.
This method could be a lot simpler without SESE. Just return if active is not null. The default return can be direct return tracer.extract()
There was a problem hiding this comment.
you're right, it's because I extracted this method and didn't review it later ;)
|
Ok, I will work on adding tests for that. |
|
FYI: it's "in progress". I've added the first test checking this functionality. |
|
It looks good, could you please add the test to other jax-rs providers? |
|
@pavolloffay Sure, I will work on it probably today. |
Proof of concept for #67.
If there is active span already (probably initialized in a different filter, e.g. servlet filter), we should use it instead of extracting a new one from HTTP headers.
How do you think would be the best way to test that?