Extended traced_attributes scope to after_request (response) too #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks! |
Closed
|
Hello @lukacsg, |
|
Hello @Jamim Thank you for working on this PR! |
|
@Jamim @carlosalberto Thank you in advance. |
|
This package is no longer being maintained, users should migrate to the Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Traced_attributes is given and scanned in _after_request_fn too.
The motivation is that this way the attributes of the response object could be presented in the trace also.
Our goal is to have more control over the traced attributes because our task requires also the input and the output data in one point.