This repository has been archived by the owner on May 23, 2023. It is now read-only.
Pass options along when creating a span with StartSpanFromContext #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you mind adding unit tests? |
|
here you go. |
bhs
reviewed
Sep 22, 2016
| @@ -21,6 +21,7 @@ func nextFakeID() int { | |||
| type testSpanContext struct { | |||
| HasParent bool | |||
| FakeID int | |||
| Options *StartSpanOptions | |||
There was a problem hiding this comment.
I'd have a slight preference to just add tags to testSpan and test that they get passed through correctly... if you don't feel like implementing this, I can do it :)
gwik
commented
Sep 22, 2016
| @@ -28,6 +29,35 @@ func (n testSpanContext) ForeachBaggageItem(handler func(k, v string) bool) {} | |||
| type testSpan struct { | |||
| spanContext testSpanContext | |||
| OperationName string | |||
| StartTime time.Time | |||
| Tags map[string]interface{} | |||
There was a problem hiding this comment.
struct equality won't work with a map member, so I implemented an Equal method.
There was a problem hiding this comment.
maybe adding an id and compare it would make more sense.
|
Thanks @gwik... the test LGTM but I will give @yurishkuro a chance to provide feedback if he so desires... |
yurishkuro
approved these changes
Sep 22, 2016
yurishkuro
suggested changes
Sep 22, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Options were ignored when creating a span.