This repository has been archived by the owner on May 23, 2023. It is now read-only.
add ipv4Tag type for peer.ipv4 to support add ipv4 string to the span
#155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
reviewed
Jul 27, 2017
ext/tags.go
Outdated
| PeerHostIPv4 = uint32TagName("peer.ipv4") | ||
|
|
||
| // PeerHostIPv4String records IP v4 host address of the peer as a .-separated tuple. E.g., "127.0.0.1" | ||
| PeerHostIPv4String = stringTagName("peer.ipv4") |
There was a problem hiding this comment.
don't know if it's worth it, but it occurred to me that instead of a separate const we could define a new dedicated type for ipv4 that would have both Set(uint32) and SetString(string) methods. This would keep it both backwards compatible and keep the single public constant name.
There was a problem hiding this comment.
PeerHostIPv4 = ipv4TagName("peer.ipv4")
type ipv4TagName string
func (tag ipv4TagName) Set(span opentracing.Span, value uint32) {
span.SetTag(string(tag), value)
}
func (tag ipv4TagName) SetString(span opentracing.Span, value string) {
span.SetTag(string(tag), value)
}Just like this?
…tString(string) methods, remove the separate const `PeerHostIPv4String`
NeoCN
changed the title
peer.ipv4 as a string tagpeer.ipv4 to support add ipv4 string to the span
yurishkuro
approved these changes
Jul 28, 2017
|
@yurishkuro just want to know when will this pr and #152 be merged in master? We need them! Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #154