Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

AsyncioScopeManager based on contextvars and supporting Tornado 6 #118

Merged
Prev Previous commit
Next Next commit
Update testbed/test_multiple_callbacks/README.md
Co-Authored-By: Yuri Shkuro <yurishkuro@users.noreply.github.com>
  • Loading branch information
condorcet and yurishkuro authored Dec 10, 2019
commit 474f4c6145df72623f5c0ec6c93a1cac777f20e5
2 changes: 1 addition & 1 deletion testbed/test_multiple_callbacks/README.md
Original file line number Diff line number Diff line change
@@ -8,7 +8,7 @@ Implementation details:
- For `threading`, a thread-safe counter is put in each `Span` to keep track of the pending callbacks, and call `Span.finish()` when the count becomes 0.
- For `gevent`, `tornado`, `asyncio` and `contextvars` the children coroutines representing the subtasks are simply yielded over, so no counter is needed.
- For `tornado`, the invoked coroutines do not set any active `Span` as doing so messes the used `StackContext`. So yielding over **multiple** coroutines is not supported.
- For `contextvars`, parent context propagating to the children coroutines implicitly, manual context activation has been avoided.
- For `contextvars`, parent context is propagated to the children coroutines implicitly, manual context activation has been avoided.

`threading` implementation:
```python