Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FareComponent #5396

Closed
leonardehrenfried opened this issue Oct 5, 2023 · 2 comments · Fixed by #5613
Closed

Remove FareComponent #5396

leonardehrenfried opened this issue Oct 5, 2023 · 2 comments · Fixed by #5613

Comments

@leonardehrenfried
Copy link
Member

leonardehrenfried commented Oct 5, 2023

FareComponent is a representation of a fare price being valid for several legs. It has however, been superseded by FareProducts and explicit mappings to legs. Unfortunately we have now 2 representations that are similar but subtly incompatible. Keeping them in sync is very complicated and leads to many bugs.

For this reason, @optionsome and I agreed that HSL, who is the only remaining user of the FareComponent, is going to move off the old component based API to the new leg-based Fares API.

Timing

Before the removal can happen HSL must move their frontend to the new Fares API. @optionsome will report in this issue when this has happened.

Backwards-compatibility

HSL have agreed that they don't need backwards-compatibility with the old API which has been deprecated for a while. The types will stay in the GraphQL schema but it will always return an empty result.

@leonardehrenfried
Copy link
Member Author

@optionsome @nurmAV Can you give an update on the removal?

@optionsome
Copy link
Member

Digitransit no longer uses the old fare API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants