Fix IBI fare calculators

[leonardehrenfried]

Summary

#5284 introduced a regression which broke IBI's fare calculators.

The problem was that leg products were not transferred correctly from the intermediary fares to the eventual result, which is fixed now.

Another problem was that HSL and IBI use different APIs for representing the fares. We hope to address this in #5396

Issue

Relates to #5396

Unit tests

Lots added and adjusted.

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (3a1518c) 66.60% compared to head (fd232c8) 66.59%.
Report is 2 commits behind head on dev-2.x.

Additional details and impacted files

@@              Coverage Diff              @@
##             dev-2.x    #5397      +/-   ##
=============================================
- Coverage      66.60%   66.59%   -0.01%     
- Complexity     15279    15284       +5     
=============================================
  Files           1790     1790              
  Lines          69368    69388      +20     
  Branches        7306     7307       +1     
=============================================
+ Hits           46204    46212       +8     
- Misses         20688    20700      +12     
  Partials        2476     2476              

Files	Coverage Δ
...ntripplanner/ext/fares/FaresToItineraryMapper.java	94.73% <100.00%> (+0.61%)	⬆️
...tripplanner/ext/fares/impl/AtlantaFareService.java	78.12% <100.00%> (+0.11%)	⬆️
...opentripplanner/ext/fares/impl/HSLFareService.java	68.26% <100.00%> (ø)
...pentripplanner/ext/fares/impl/OrcaFareService.java	76.77% <100.00%> (+0.09%)	⬆️
...org/opentripplanner/model/fare/ItineraryFares.java	88.00% <100.00%> (+1.04%)	⬆️
...tripplanner/ext/fares/impl/DefaultFareService.java	92.07% <96.00%> (+0.50%)	⬆️
...pplanner/ext/fares/impl/HSLFareServiceFactory.java	0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[binh-dam-ibigroup]

Works locally, bringing the fare info back!