Fix race condition in GtfsModuleTest #5357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Arguments.of(List.of(bundle("A"), bundle("B"), bundle("C")), 6) | ||
| ); | ||
| static Stream<Arguments> interliningCases() { | ||
| return Stream.of( |
There was a problem hiding this comment.
Suggested change
| return Stream.of( | |
| return List.of( |
Probably ok without but safer if you switch to a List.
There was a problem hiding this comment.
You need to check if it works with MethodSource
There was a problem hiding this comment.
I think we would be ok with a stream but changed to List just to be sure.
There was a problem hiding this comment.
MethodSource works with any collection.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5357 +/- ##
=============================================
- Coverage 66.43% 66.41% -0.03%
+ Complexity 15210 15206 -4
=============================================
Files 1786 1786
Lines 69239 69239
Branches 7311 7311
=============================================
- Hits 46001 45982 -19
- Misses 20761 20782 +21
+ Partials 2477 2475 -2
☔ View full report in Codecov by Sentry. |
habrahamsson-skanetrafiken
force-pushed
the
fix-test-racecondition
branch
from
23c9703 to
45b459d
Compare
leonardehrenfried
approved these changes
Sep 14, 2023
t2gran
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is intermittently failing in our ci pipeline with error:
There is probably some kind of race condition. This PR fixes this by switching to using MethodSource.