Fix rental scooter access

[leonardehrenfried]

Summary

This fixes the scooter rental access computation when geofencing zones are deactivated. The problem was that the StreetTransitStopLink edge didn't allow rental scooters to traverse.

Issue

Closes #5356

Unit tests

Lots of test cases added.

[codecov]

Codecov Report

Patch coverage: 80.00% and project coverage change: +0.01% 🎉

Comparison is base (a27baf3) 66.49% compared to head (7149a68) 66.51%.
Report is 2 commits behind head on dev-2.x.

Additional details and impacted files

@@              Coverage Diff              @@
##             dev-2.x    #5361      +/-   ##
=============================================
+ Coverage      66.49%   66.51%   +0.01%     
- Complexity     15234    15239       +5     
=============================================
  Files           1785     1785              
  Lines          69269    69277       +8     
  Branches        7291     7293       +2     
=============================================
+ Hits           46063    46079      +16     
+ Misses         20737    20729       -8     
  Partials        2469     2469              

Files Changed	Coverage Δ
...org/opentripplanner/street/search/state/State.java	87.34% <75.00%> (+5.52%)	⬆️
...ner/street/model/edge/StreetTransitEntityLink.java	82.45% <81.81%> (+3.21%)	⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[vpaturet]

A small request, not directly related to this PR, but useful for getting into the logic: could you add some javadoc in the AStarEdge interface. In particular the meaning of the traverse() method is not obvious and a short high-level description would help, as well as few words about the meaning of the return value State.empty(), and the special case of returning multiple states (#4841)

[leonardehrenfried]

Does 9428ee7 make it any clearer, @vpaturet ?

[vpaturet]

Perfect, thank you!

[vpaturet]

This also fixes the issue I mentioned earlier where direct routing to a station would not return a scooter rental leg:

trip(
    from: {
      name: "Gulleråsen"
      place: "NSR:StopPlace:6294"
    },
    to: {
      name: "Telthusbakken" 
      place: "NSR:StopPlace:6290"
    },
    dateTime: "2023-08-11T12:48:50.467+02:00",
    modes: {
      directMode: scooter_rental
    }
  )

while using coordinates would succeeds:

trip(
  from: {
    name: "Gulleråsen"
    place: "NSR:StopPlace:6294"
  },
  to: {
    name: "Telthusbakken",
    coordinates: {
      latitude: 59.924565
      longitude: 10.750507
    }
    
 },
  dateTime: "2023-08-11T12:48:50.467+02:00",
  modes: {
    directMode: scooter_rental
  }
)

Now both queries return similar results.

[optionsome]

Is u again some term from A* literature or java naming convention? Could we have a more descriptive name for this variable even if this is just an interface?

[leonardehrenfried]

I'm not sure. There must be a reason why Hannes called it u. In other places it's called s0.

The A* Wikipedia page mentions neither u nor s0.

Would s0 be a good name for you?

[optionsome]

Yes that's fine