-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ID to mapper error messages #5363
Add ID to mapper error messages #5363
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5363 +/- ##
=============================================
+ Coverage 66.45% 66.48% +0.02%
- Complexity 15235 15242 +7
=============================================
Files 1787 1787
Lines 69325 69323 -2
Branches 7319 7319
=============================================
+ Hits 46072 46089 +17
+ Misses 20778 20757 -21
- Partials 2475 2477 +2
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. However, I did some tests:
- stop_times refers to station -> error is thrown
- stop's parent station is stop -> no error
- transfer between stations -> no error
- station has parent stop -> no error
Can you double check that station mapper error throwing works as expected?
Does it work with current dev-2.x? |
dev-2.x behaves the same way. I just found it odd that it seems difficult to hit that validation check. There are no regressions - just better quality code - so I will approve this PR. |
Summary
Similarly to #4993 this improves the error messages when an entry from a stops.txt has an incorrect location_type, for example when you try to generate a transfer from a station to a station.
cc @NVBWSeifert