Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix value mapping for bikesAllowed in GTFS GraphQL API #5368

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

leonardehrenfried
Copy link
Member

Summary

If you request the bikesAllowed resolver of the GTFS API it would incorrectly return the value NOT_POSSIBLE when it should be NOT_ALLOWED, according to the schema. This would lead to an error for the resolver instead of the value.

This PR fixes this problem.

Unit tests

Added.

@leonardehrenfried leonardehrenfried requested a review from a team as a code owner September 21, 2023 11:32
@leonardehrenfried leonardehrenfried changed the title Fix values for bikesAllowed in GTFS GraphQL API Fix value mapping for bikesAllowed in GTFS GraphQL API Sep 21, 2023
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage: 71.42% and project coverage change: +0.01% 🎉

Comparison is base (a27baf3) 66.49% compared to head (0abf7f3) 66.51%.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #5368      +/-   ##
=============================================
+ Coverage      66.49%   66.51%   +0.01%     
- Complexity     15234    15236       +2     
=============================================
  Files           1785     1786       +1     
  Lines          69269    69266       -3     
  Branches        7291     7291              
=============================================
+ Hits           46063    46069       +6     
+ Misses         20737    20728       -9     
  Partials        2469     2469              
Files Changed Coverage Δ
.../gtfsgraphqlapi/generated/GraphQLDataFetchers.java 0.00% <ø> (ø)
...ext/gtfsgraphqlapi/mapping/BikesAllowedMapper.java 60.00% <60.00%> (ø)
...ner/ext/gtfsgraphqlapi/datafetchers/RouteImpl.java 20.61% <100.00%> (+0.81%) ⬆️
...nner/ext/gtfsgraphqlapi/datafetchers/TripImpl.java 19.18% <100.00%> (+0.43%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leonardehrenfried leonardehrenfried merged commit a203530 into opentripplanner:dev-2.x Sep 25, 2023
t2gran pushed a commit that referenced this pull request Sep 25, 2023
@leonardehrenfried leonardehrenfried deleted the bikes-allowed branch September 25, 2023 10:19
@t2gran t2gran added this to the 2.5 (next release) milestone Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants