-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve geocoding fuzziness, remove street corners #5401
Improve geocoding fuzziness, remove street corners #5401
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5401 +/- ##
=============================================
+ Coverage 66.59% 66.64% +0.05%
- Complexity 15284 15290 +6
=============================================
Files 1790 1791 +1
Lines 69388 69389 +1
Branches 7308 7306 -2
=============================================
+ Hits 46206 46244 +38
+ Misses 20704 20668 -36
+ Partials 2478 2477 -1
☔ View full report in Codecov by Sentry. |
Add test for rounding. |
@flaktack Could you perhaps review this? |
cb81df0
to
3dcbc98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The NONE Sandbox changes look good! I have not looked at the code in the Sandbox.
src/ext/java/org/opentripplanner/ext/geocoder/EnglishNGramAnalyzer.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Zsombor Welker <flaktack@users.noreply.github.com>
Summary
@miles-grant-ibigroup has requested the following changes to the sandbox geocoder:
Feature removal
This PR also removes the street corners from the geocoding index, which improves startup time. @flaktack, who originally added it, said that he would be fine if it was removed.
Unit tests
Lots added.
Documentation
Updated.