-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fare calculation for combined interlined legs #5408
Merged
leonardehrenfried
merged 4 commits into
opentripplanner:dev-2.x
from
ibi-group:fix-septa-calculator
Oct 12, 2023
Merged
Fix fare calculation for combined interlined legs #5408
leonardehrenfried
merged 4 commits into
opentripplanner:dev-2.x
from
ibi-group:fix-septa-calculator
Oct 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardehrenfried
force-pushed
the
fix-septa-calculator
branch
from
October 9, 2023 13:00
ce3045f
to
c511d44
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5408 +/- ##
=============================================
- Coverage 66.59% 66.59% -0.01%
- Complexity 15285 15286 +1
=============================================
Files 1790 1790
Lines 69384 69392 +8
Branches 7307 7309 +2
=============================================
+ Hits 46207 46210 +3
- Misses 20700 20703 +3
- Partials 2477 2479 +2
☔ View full report in Codecov by Sentry. |
binh-dam-ibigroup
previously approved these changes
Oct 11, 2023
src/ext-test/java/org/opentripplanner/ext/fares/impl/CombinedInterlinedLegsFareServiceTest.java
Outdated
Show resolved
Hide resolved
src/ext-test/java/org/opentripplanner/ext/fares/impl/CombinedInterlinedLegsFareServiceTest.java
Show resolved
Hide resolved
binh-dam-ibigroup
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a problem when interlined legs area combined for fare calculation purposes: the fare products are associated to the wrong legs because the combined leg is not "deconstructed" into its parts when returning the results.
@binh-dam-ibigroup: this bugfix is relevant when Houston and SEPTA are going migrate the new Fares API.
Unit tests
Added.
Documentation
Javadoc added.