Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Money serializable #5419

Merged

Conversation

leonardehrenfried
Copy link
Member

@leonardehrenfried leonardehrenfried commented Oct 11, 2023

Summary

@fpurcell has reported (and I have independently also noticed) that when enabling Fares V2 Money objects fail serialization because they are not Serializable.

This PR fixes that.

Unit tests

I'd love to write one but I'm not sure if it's worth it. Test added.

@leonardehrenfried leonardehrenfried added Bug bump serialization id Add this label if you want the serialization id automatically bumped after merging the PR labels Oct 11, 2023
@leonardehrenfried leonardehrenfried requested a review from a team as a code owner October 11, 2023 07:54
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9695a96) 66.59% compared to head (faed0c2) 66.59%.
Report is 5 commits behind head on dev-2.x.

Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #5419   +/-   ##
==========================================
  Coverage      66.59%   66.59%           
- Complexity     15284    15286    +2     
==========================================
  Files           1790     1790           
  Lines          69388    69388           
  Branches        7308     7308           
==========================================
+ Hits           46206    46207    +1     
  Misses         20703    20703           
+ Partials        2479     2478    -1     
Files Coverage Δ
...org/opentripplanner/transit/model/basic/Money.java 76.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leonardehrenfried leonardehrenfried merged commit 2e7a047 into opentripplanner:dev-2.x Oct 12, 2023
5 checks passed
t2gran pushed a commit that referenced this pull request Oct 12, 2023
@leonardehrenfried leonardehrenfried deleted the money-serializable branch October 12, 2023 21:03
@t2gran t2gran added this to the 2.5 (next release) milestone Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug bump serialization id Add this label if you want the serialization id automatically bumped after merging the PR Skip Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants