Add via to the Transmodel trip query and make a proper Raptor implementation for it #6084

t2gran · 2024-09-22T19:06:02Z

Summary

This PR add back the via search to the Transmodel plan query. It does so by "chaining" Raptor requests. To be able to do this I had to refactor quite a bit. The functional changes is not that big.

This PR changes the Transmodel API and add a via location to the plan request. The passThrough feature works as before, but is merged with the new via API, and the old passThrough arguments are deprecated.

There are a few things left to implement:

I will create issues for reminding features, when this is merged.

The feature is a bit experimental and need "real life" testing - small changes and bug fixes are expected.

If this PR is too massive, then I can split it - but I believe there is little risk in breaking existing functionality. Splitting it in a pure feature PR and refactorings is difficult.

Issue

Related to : #4887

Unit tests

This PR refactor a lot of code and also add missing unit-test to some of the refactored classes. Almost all new code have unit-tests.

Documentation

✅ The API is documented and all new public classes/methods should have JavaDoc.

Changelog

✅

Bumping the serialization version id

✅ The routing request is changed

…ntation

…dProvider

…om dynamicSearchParamsCalculator)

This extract logic to merge a hierarchy of objects containing composites, flatten the structure into one list of elements. There is a small performance optimization, but the important thing is that we will use this later in the design later.

Parameters for via locations with wait-time and allowAsPassThroughPoint flag are added.

…with ViaLocation

leonardehrenfried · 2024-09-24T12:55:11Z

src/main/java/org/opentripplanner/apis/transmodel/model/framework/TransmodelScalars.java

+ DATE_SCALAR = DateScalarFactory.createTransmodelDateScalar();
+ DOUBLE_FUNCTION_SCALAR = DoubleFunctionFactory.createDoubleFunctionScalar();
+ LOCAL_TIME_SCALAR = LocalTimeScalarFactory.createLocalTimeScalar();
+ TIME_SCALAR = TimeScalarFactory.createSecondsSinceMidnightAsTimeObject();
+ DURATION_SCALAR = DurationScalarFactory.createDurationScalar();


What is the reason this is in a static initializer and not done during variable assignment?

Just readablility, the lines would break.

src/main/java/org/opentripplanner/apis/transmodel/model/plan/ViaLocationInputType.java

leonardehrenfried · 2024-09-24T12:58:06Z

src/main/resources/org/opentripplanner/apis/transmodel/schema.graphql

+One of the listed stop locations must be visited on-board a transit vehicle or the journey must
+alight or board at the location.
+"""
+input PlanPassThroughViaLocationInput {


Does the Transmodel API use the "plan" terminology?

leonardehrenfried · 2024-09-24T12:58:57Z

src/main/resources/org/opentripplanner/apis/transmodel/schema.graphql

+the closest point in the street network from a stop and back to another stop to join
+the transit network.
+
+NOTE! Coordinates are NOT supported jet.


Suggested change

NOTE! Coordinates are NOT supported jet.

NOTE! Coordinates are NOT supported yet.

Are you sure that you want to allow clients to define both the coordinates and stopLocationIds in the same object with one being silently used as a fallback?

src/main/java/org/opentripplanner/apis/transmodel/support/OneOfInputValidator.java

leonardehrenfried · 2024-09-24T13:11:54Z

src/main/java/org/opentripplanner/raptor/api/request/RaptorViaConnection.java

+ * transit, or at the alight- or board-stop. The from-stop and to-stop is the same, and the
+ * minimum-wait-time must be zero.


Can you explain the last sentence? Does it mean that you can only get off and then on again at the very same stop?

No, to specify a passThroughStop from === to- only one visit to the stop is requiered - can be on-board. I will consider changing the design later.

src/main/java/org/opentripplanner/raptor/rangeraptor/context/SearchContext.java

leonardehrenfried · 2024-09-24T13:20:35Z

src/main/java/org/opentripplanner/raptor/rangeraptor/internalapi/RaptorRouter.java

+import org.opentripplanner.raptor.api.model.RaptorTripSchedule;
+
+/**
+ * Interface for Raptor Router. Allow instrumentation/wrapping the router. This is not


Is this still true?

leonardehrenfried · 2024-09-24T13:21:24Z

src/main/java/org/opentripplanner/raptor/rangeraptor/multicriteria/McStopArrivals.java


- private final ArrivalParetoSetComparatorFactory<McStopArrival<T>> comparatorFactory;
+ //private final ArrivalParetoSetComparatorFactory<McStopArrival<T>> comparatorFactory;


Can this line be deleted?

src/main/java/org/opentripplanner/raptor/api/request/RaptorViaLocation.java

src/main/java/org/opentripplanner/raptor/service/ViaRangeRaptorDynamicSearch.java

...opentripplanner/routing/algorithm/raptoradapter/transit/mappers/LookupStopIndexCallback.java

leonardehrenfried · 2024-09-25T11:10:57Z

...org/opentripplanner/routing/algorithm/raptoradapter/transit/mappers/RaptorRequestMapper.java

@@ -115,7 +129,9 @@ private RaptorRequest<T> doMap() {
 var r = pt.raptor();

 // Note! If a pass-through-point exists, then the transit-group-priority feature is disabled
- if (!request.getPassThroughPoints().isEmpty()) {
+
+ // TODO - We need handle via locations that are not pass-through-points here


Suggested change

// TODO - We need handle via locations that are not pass-through-points here

// TODO - We need to handle via locations that are not pass-through-points here

leonardehrenfried · 2024-09-25T11:17:12Z

src/main/java/org/opentripplanner/transit/service/TransitService.java

+ /**
+ * Return all stops associated with the given id. If a Station, a MultiModalStation, or a
+ * GroupOfStations matches the id, then all child stops are returned. If the id matches a regular
+ * stops, area stop or stop group, then a list with one item is returned.


Suggested change

* stops, area stop or stop group, then a list with one item is returned.

* stop, area stop or stop group, then a list with one item is returned.

leonardehrenfried

I've read through this PR and left comments.

My main feedback:

graphql-java has supported @OneOf for a while. does it not work for you?
I would like to know why the stopId/coordinate fallback strategy was chosen.

leonardehrenfried · 2024-09-25T11:58:37Z

Also, you need to resolve some conflicts.

src/main/java/org/opentripplanner/apis/transmodel/support/OneOfInputValidator.java

src/main/java/org/opentripplanner/raptor/api/request/RaptorViaConnection.java

t2gran · 2024-09-26T12:50:20Z

src/main/java/org/opentripplanner/raptor/api/request/RaptorViaConnection.java

+ * transit, or at the alight- or board-stop. The from-stop and to-stop is the same, and the
+ * minimum-wait-time must be zero.


No, to specify a passThroughStop from === to- only one visit to the stop is requiered - can be on-board. I will consider changing the design later.

…Connection.java

src/main/java/org/opentripplanner/raptor/rangeraptor/multicriteria/McStopArrivals.java

t2gran · 2024-09-26T12:58:28Z

@t2gran Do you expect this PR to change the performance?

No, chaning Raptor Request should only affect performance for via searches. There are minor changes in the Raptor instrumentation (not in logic), so it might cause some problems for the JIT compiler - but I expect that it should not change.

Co-authored-by: Leonard Ehrenfried <mail@leonard.io>

t2gran · 2024-09-30T08:52:34Z

src/main/java/org/opentripplanner/raptor/rangeraptor/multicriteria/McStopArrivals.java

+ viaConnections
+ .byFromStop()
+ .forEachEntry((stop, connections) -> {
+ this.arrivals[stop] =


This is OK, I though that the egress would overwrite this if the egress and vi was the same stop, but a McStopArrivals is 1-to-1 with the worker, so it has either via stops or egress, not both.

habrahamsson-skanetrafiken · 2024-09-30T09:14:02Z

...ain/java/org/opentripplanner/raptor/rangeraptor/standard/configure/StdRangeRaptorConfig.java

+ egressPaths().egressesWitchStartByWalking(),
+ egressPaths().egressesWitchStartByARide()


An existing typo.

Suggested change

egressPaths().egressesWitchStartByWalking(),

egressPaths().egressesWitchStartByARide()

egressPaths().egressesWhichStartByWalking(),

egressPaths().egressesWhichStartByARide()

habrahamsson-skanetrafiken · 2024-10-03T09:44:01Z

src/main/java/org/opentripplanner/apis/transmodel/support/GqlUtil.java

 /** private to prevent util class from instantiation */
 public GqlUtil(ZoneId timeZone) {


Not related to anything you did, but this comment is wrong. This seems to be instantiated in a test.

habrahamsson-skanetrafiken · 2024-10-03T09:52:30Z

src/main/java/org/opentripplanner/framework/time/DurationUtils.java

+ @Deprecated
 public static Duration requireNonNegativeLong(Duration value, String subject) {


This is nice, but now these deprecated methods could delegate to the new generic method instead of having their own implementations right?

habrahamsson-skanetrafiken · 2024-10-03T09:59:09Z

src/main/java/org/opentripplanner/raptor/api/request/RaptorViaConnection.java

+ * the connection to visit something other than a stop, like a street location. The result should be
+ * 100 connections. This is not an alternative to transfers. Raptor supports several use-cases


This sentence doesn't make sense to me, it probably belongs in the example further down.

Suggested change

* the connection to visit something other than a stop, like a street location. The result should be

* 100 connections. This is not an alternative to transfers. Raptor supports several use-cases

* the connection to visit something other than a stop, like a street location.

* This is not an alternative to transfers. Raptor supports several use-cases

habrahamsson-skanetrafiken · 2024-10-03T10:00:45Z

src/main/java/org/opentripplanner/raptor/api/request/RaptorViaConnection.java

+ * <h4>Route via a coordinate</h4>
+ *
+ * To route through a coordinate you need to find all nearby stops, then find all access and egress
+ * paths to and from the street location. The combine all access and egress paths to form


Suggested change

* paths to and from the street location. The combine all access and egress paths to form

* paths to and from the street location. Then combine all access and egress paths to form

habrahamsson-skanetrafiken · 2024-10-04T08:42:20Z

src/main/java/org/opentripplanner/raptor/rangeraptor/context/SearchContextViaLeg.java

+ }
+
+ /**
+ * The egress path for search, if and only if this is the last leg.


Suggested change

* The egress path for search, if and only if this is the last leg.

* The egress path for search. Non-null if and only if this is the last leg.

habrahamsson-skanetrafiken · 2024-10-04T08:46:33Z

src/main/java/org/opentripplanner/raptor/rangeraptor/multicriteria/McStopArrivals.java


 /**
 * Set the time at a transit index iff it is optimal. This sets both the best time and the
 * transfer time
 */
 public McStopArrivals(
 int nStops,
- EgressPaths egressPaths,
 AccessPaths accessPaths,


It looks like we're not using this accessPaths parameter anymore.

habrahamsson-skanetrafiken · 2024-10-04T08:48:13Z

src/main/java/org/opentripplanner/raptor/rangeraptor/multicriteria/McStopArrivals.java

 DestinationArrivalPaths<T> paths,
+ McStopArrivals<T> next,


Maybe this could have a more descriptive name, like nextLegStopArrivals or something like that?

habrahamsson-skanetrafiken · 2024-10-04T08:56:23Z

src/main/java/org/opentripplanner/raptor/rangeraptor/multicriteria/McStopArrivals.java

 EgressPaths egressPaths,
 DestinationArrivalPaths<T> paths


Suggested change

EgressPaths egressPaths,

DestinationArrivalPaths<T> paths

@Nullable EgressPaths egressPaths,

DestinationArrivalPaths<T> paths

habrahamsson-skanetrafiken · 2024-10-04T08:59:42Z

...java/org/opentripplanner/raptor/rangeraptor/multicriteria/arrivals/McStopArrivalFactory.java

@@ -20,4 +21,27 @@ McStopArrival<T> createTransferStopArrival(
 RaptorTransfer transfer,
 int arrivalTime
 );
+
+ default McStopArrival<T> createViaStopArrival(


Suggested change

default McStopArrival<T> createViaStopArrival(

@Nullable

default McStopArrival<T> createViaStopArrival(

optionsome

This is purely a code review and I didn't even review the tests (yet).

optionsome · 2024-10-04T16:32:01Z

src/main/java/org/opentripplanner/apis/transmodel/mapping/TripRequestMapper.java

+ }
+ );
+ callWith.argument(
+ TripQuery.FIELD_VIA,


I think the root parameters of a query are called parameters. GraphQL's official website seems to call the fields inside input types fields.

optionsome · 2024-10-04T16:46:52Z

src/main/java/org/opentripplanner/apis/transmodel/support/OneOfInputValidator.java

+ * Validate @oneOf directive, this validation is NOT done by the Java GraphQL library at the
+ * moment(v22.1). Remove this when enforced by the library. The {@code @oneOf} is an experimental
+ * feature in this version of the library.


Could probably specify here that the GraphQL java doesn't do the validation when the API is implemented like way the Transmodel API is implemented through code-first approach.

optionsome · 2024-10-04T16:51:00Z

src/main/java/org/opentripplanner/apis/transmodel/mapping/ViaLocationDeprecatedMapper.java

 import org.opentripplanner.routing.api.response.RoutingError;
 import org.opentripplanner.routing.api.response.RoutingErrorCode;
 import org.opentripplanner.routing.error.RoutingValidationException;

-class ViaLocationMapper {
+@Deprecated
+class ViaLocationDeprecatedMapper {


We should probably figure out some unified naming for these types of classes. I think I've called them LegacySomething in the past and in this pr, sometimes the legacy word is used to refer to the old implementation.

optionsome · 2024-10-04T16:53:49Z

src/main/java/org/opentripplanner/apis/transmodel/model/framework/TransmodelDirectives.java

+ public static final GraphQLDirective TIMING_DATA = GraphQLDirective
+ .newDirective()
+ .name("timingData")
+ .description("Add timing data to prometheus, if Actuator API is enabled")
+ .validLocation(Introspection.DirectiveLocation.FIELD_DEFINITION)
+ .build();


I know this isn't implemented within the scope of this pr but it feels weird to expose this type of information through the schema to API users or do we somehow remove this from the introspection response?

optionsome · 2024-10-04T17:09:03Z

src/main/java/org/opentripplanner/apis/transmodel/model/plan/ViaLocationInputType.java

+ A visit-via-location is a physical visit to one of the stops or coordinates listed. An
+ on-board visit does not count, the traveler must alight or board at the given stop for
+ it to to be accepted. To visit a coordinate, the traveler must walk(bike or drive) to
+ the closest point in the street network from a stop and back to another stop to join
+ the transit network.


I remember we discussed how the visit stops should work in some previous developer meeting and I remember there were some differing opinions around it. I do see the benefit of being able to specify a boarding/alighting stop but I also would see benefit in being able to specify a station as a via location without actually needing to connect to the transit network at said station, similarly as we currently support for origin and destination. Although, we don't support direct street via searches so it gives us more options.

optionsome · 2024-10-04T19:22:12Z

src/main/resources/org/opentripplanner/apis/transmodel/schema.graphql

+One of the listed stop locations must be visited on-board a transit vehicle or the journey must
+alight or board at the location.


Was it possible with pass through points that you walk from the origin to a passthrough stop and board from there (not just from walking from a transfer stop)?

optionsome · 2024-10-04T19:23:47Z

src/main/resources/org/opentripplanner/apis/transmodel/schema.graphql

+"""
+A via-location is used to specifying a location as an intermediate place the router must
+route through. The via-location must be either a pass-through-location or a
+visit-via-location. An on-board "visit" is only allowed for pass-through-via-locations, while
+the visit-via-location can visit a stop-location or a coordinate and specify a
+minimum-wait-time.
+"""


"An on-board "visit" is only allowed for pass-through-via-locations" this can be interpreted in two ways, either it limits the passthrough point or a visit point. The difference between the two types is not completely clear as it's not clear what visit means and sometimes passthrough point and visit stop location both act similarly as a boarding/alighting location.

optionsome · 2024-10-04T19:26:22Z

src/main/resources/org/opentripplanner/apis/transmodel/schema.graphql

+ passThrough: PlanPassThroughViaLocationInput
+ visit: PlanVisitViaLocationInput


These are missing descriptions. I think we usually put descriptions both on the field and on the type.

optionsome · 2024-10-04T19:28:50Z

src/main/resources/org/opentripplanner/apis/transmodel/schema.graphql

+it to to be accepted. To visit a coordinate, the traveler must walk(bike or drive) to
+the closest point in the street network from a stop and back to another stop to join
+the transit network.


I guess here it could be explicitly specified that walking from origin to a coordinate or from a coordinate to destination is not allowed, even though you sort of say it here.

optionsome · 2024-10-04T19:31:16Z

src/main/resources/org/opentripplanner/apis/transmodel/schema.graphql

+ A list of stop locations. A stop location can be a quay, a stop place, a multimodal
+ stop place or a group of stop places. It is enough to visit ONE of the locations
+ listed.


So once we add coordinates, it's enough that either one of the stop locations or coordinates is visited if both are defined?

t2gran added 13 commits September 22, 2024 19:56

refactor: Remove RaptorWorker usage

6abd293

refactor: Rename DefaultRangeRaptorWorker to RangeRaptor

1420ab3

refactor: Rename RaptorWorker interface - unused p.t.

0ada612

refactor: Split RangeRaptor in a pure driver and an algorithm impleme…

97a2621

…ntation

refactor: Use WorkerLifeCycle to inject round counter and remove Roun…

b952ad8

…dProvider

refactor: Reintroduce the RangeRaptorWorker interface - one level down.

edda318

refactor: Move RaptorStopNameResolver to package o.o.raptor.api.model

07b7c22

feature: Add raptor Via search API

7dd0252

refactor: Improve local field name: dynamicSearchWindowCalculator (fr…

1d6a7f1

…om dynamicSearchParamsCalculator)

refactor: Minor cleanups in Raptor - no logic changed.

5a7f9c8

refactor: Arrange methods in AccessPaths

6e6f69d

refactor: Extract builder out of SearchContext (o.o.r.rr.context)

1fa7ad8

t2gran added New Feature bump serialization id Add this label if you want the serialization id automatically bumped after merging the PR labels Sep 22, 2024

t2gran added this to the 2.7 (next release) milestone Sep 22, 2024

t2gran requested a review from a team as a code owner September 22, 2024 19:06

t2gran added 13 commits September 22, 2024 21:10

feature: Add via search to Raptor

8dbafdb

refactor: Deprecate old vi search.

d769612

refactor: Rename field in PassThroughPoint

fe37d94

refactor: Deprecate ViaLocationMapper

b672ff7

refactor: Rename PassThroughPoint to ViaLocation

1249901

refactor: Rename PassThroughLocationMapper to ViaLocationMapper

bab588e

refactor: Add parameters to the ViaLocation

add5edc

Parameters for via locations with wait-time and allowAsPassThroughPoint flag are added.

refactor: Rename request getPassThroughPoints() to getViaLocations()

5e00c29

refactor: Refactor PassThroughPoint request arguments and replace it …

a534f33

…with ViaLocation

refactor: Make to kinds of ViaLocation in request: PassThrough and Visit

756f7a4

refactor: Delete unused ViaConnection

26e41f4

refactor: Move via request classes into via package

496aa5d

refactor: Hide legacy ViaSearch in Transmodel API in its own package

14b8562

leonardehrenfried reviewed Sep 24, 2024

View reviewed changes

src/main/java/org/opentripplanner/apis/transmodel/model/plan/ViaLocationInputType.java Outdated Show resolved Hide resolved

leonardehrenfried reviewed Sep 24, 2024

View reviewed changes

src/main/java/org/opentripplanner/apis/transmodel/support/OneOfInputValidator.java Show resolved Hide resolved

leonardehrenfried reviewed Sep 24, 2024

View reviewed changes

src/main/java/org/opentripplanner/raptor/rangeraptor/context/SearchContext.java Outdated Show resolved Hide resolved

leonardehrenfried reviewed Sep 24, 2024

View reviewed changes

leonardehrenfried reviewed Sep 25, 2024

View reviewed changes

src/main/java/org/opentripplanner/raptor/api/request/RaptorViaLocation.java Outdated Show resolved Hide resolved

leonardehrenfried reviewed Sep 25, 2024

View reviewed changes

src/main/java/org/opentripplanner/raptor/service/ViaRangeRaptorDynamicSearch.java Outdated Show resolved Hide resolved

leonardehrenfried reviewed Sep 25, 2024

View reviewed changes

src/main/java/org/opentripplanner/raptor/service/ViaRangeRaptorDynamicSearch.java Outdated Show resolved Hide resolved

leonardehrenfried reviewed Sep 25, 2024

View reviewed changes

...opentripplanner/routing/algorithm/raptoradapter/transit/mappers/LookupStopIndexCallback.java Outdated Show resolved Hide resolved

leonardehrenfried reviewed Sep 25, 2024

View reviewed changes

leonardehrenfried requested changes Sep 25, 2024

View reviewed changes

t2gran commented Sep 26, 2024

View reviewed changes

Update src/main/java/org/opentripplanner/raptor/api/request/RaptorVia…

4b475ff

…Connection.java

t2gran commented Sep 26, 2024

View reviewed changes

src/main/java/org/opentripplanner/raptor/rangeraptor/multicriteria/McStopArrivals.java Outdated Show resolved Hide resolved

t2gran and others added 3 commits September 27, 2024 15:40

Apply suggestions from code review

1e679e6

Co-authored-by: Leonard Ehrenfried <mail@leonard.io>

refactor: Remove unused code in GqlUtil

ccfbbe5

feature: Make via list input fields non-null

55ba651

t2gran force-pushed the via branch from bc614ac to 55ba651 Compare September 27, 2024 13:41

t2gran added 2 commits September 27, 2024 17:16

refactor: Extract ViaConnectionStopArrivalEventListener and improve doc

d8db27f

refactor: Improve JavaDoc on RaptorViaLocation

3119605

t2gran commented Sep 30, 2024

View reviewed changes

habrahamsson-skanetrafiken requested changes Oct 4, 2024

View reviewed changes

optionsome requested changes Oct 4, 2024

View reviewed changes

	NOTE! Coordinates are NOT supported jet.
	NOTE! Coordinates are NOT supported yet.

		* transit, or at the alight- or board-stop. The from-stop and to-stop is the same, and the
		* minimum-wait-time must be zero.


		private final ArrivalParetoSetComparatorFactory<McStopArrival<T>> comparatorFactory;
		//private final ArrivalParetoSetComparatorFactory<McStopArrival<T>> comparatorFactory;

	// TODO - We need handle via locations that are not pass-through-points here
	// TODO - We need to handle via locations that are not pass-through-points here

	* stops, area stop or stop group, then a list with one item is returned.
	* stop, area stop or stop group, then a list with one item is returned.

		egressPaths().egressesWitchStartByWalking(),
		egressPaths().egressesWitchStartByARide()

		/** private to prevent util class from instantiation */
		public GqlUtil(ZoneId timeZone) {

		@Deprecated
		public static Duration requireNonNegativeLong(Duration value, String subject) {

		* the connection to visit something other than a stop, like a street location. The result should be
		* 100 connections. This is not an alternative to transfers. Raptor supports several use-cases

	* paths to and from the street location. The combine all access and egress paths to form
	* paths to and from the street location. Then combine all access and egress paths to form

	* The egress path for search, if and only if this is the last leg.
	* The egress path for search. Non-null if and only if this is the last leg.

	default McStopArrival<T> createViaStopArrival(
	@Nullable
	default McStopArrival<T> createViaStopArrival(

		One of the listed stop locations must be visited on-board a transit vehicle or the journey must
		alight or board at the location.

		passThrough: PlanPassThroughViaLocationInput
		visit: PlanVisitViaLocationInput

Add via to the Transmodel trip query and make a proper Raptor implementation for it #6084

Are you sure you want to change the base?

Add via to the Transmodel trip query and make a proper Raptor implementation for it #6084

Conversation

t2gran commented Sep 22, 2024 • edited Loading

Summary

Issue

Unit tests

Documentation

Changelog

Bumping the serialization version id

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leonardehrenfried left a comment

Choose a reason for hiding this comment

leonardehrenfried commented Sep 25, 2024

Choose a reason for hiding this comment

t2gran commented Sep 26, 2024

t2gran Sep 30, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

habrahamsson-skanetrafiken Oct 4, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

optionsome left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

t2gran commented Sep 22, 2024 •

edited

Loading

t2gran Sep 30, 2024 •

edited

Loading

habrahamsson-skanetrafiken Oct 4, 2024 •

edited

Loading