Add relay connection and global object identification specification guidelines to decision records #6193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Leonard Ehrenfried <mail@leonard.io>
optionsome
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6193 +/- ##
==========================================
Coverage 69.79% 69.79%
- Complexity 17797 17798 +1
==========================================
Files 2019 2019
Lines 76119 76119
Branches 7786 7786
==========================================
Hits 53128 53128
Misses 20285 20285
Partials 2706 2706 ☔ View full report in Codecov by Sentry. |
leonardehrenfried
requested changes
Dec 9, 2024
Co-authored-by: Leonard Ehrenfried <mail@leonard.io>
leonardehrenfried
approved these changes
Dec 9, 2024
|
✅ The changes made by @optionsome looks good to me, this is ready to be be merged. |
optionsome
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace #6080
Add a page for best practices for API Design and add a guideline for relay connection specification and for using global object identification specification.
Issue
This was discussed in the developer meeting on 19. Sep 2024
Unit tests
🟥 Not relevant
Documentation
✅ Add developer doc
Changelog
🟥 Not relevant
Bumping the serialization version id
🟥 Not relevant