Add a matcher API for filters in the transit service used for regularStop lookup

[eibakke]

Summary

This change allows for a clean separation of concerns and lays the path for more efficient filtering logic down the line.

Also moves bounding box filtering on stops from the spatial index into a shared method so that all callers don't have to do this filtering themselves.

Issue

#5630

Unit tests

Added unit tests for each matcher and the new RegularStopMatcherFactory. Also ensured that the API in local runs behaves as expected.

Documentation

Added JavaDoc.

[codecov]

Codecov Report

Attention: Patch coverage is 30.43478% with 48 lines in your changes missing coverage. Please review.

Project coverage is 69.83%. Comparing base (c7fe2f2) to head (7f5f5e3).
Report is 190 commits behind head on dev-2.x.

Files with missing lines	Patch %	Lines
...anner/apis/transmodel/TransmodelGraphQLSchema.java	31.57%	13 Missing ⚠️
.../request/FindRegularStopsByBoundingBoxRequest.java	0.00%	9 Missing ⚠️
...t/FindRegularStopsByBoundingBoxRequestBuilder.java	0.00%	9 Missing ⚠️
...odel/filter/transit/RegularStopMatcherFactory.java	22.22%	7 Missing ⚠️
...pentripplanner/ext/restapi/resources/IndexAPI.java	0.00%	2 Missing ⚠️
...r/transit/model/filter/expr/ExpressionBuilder.java	0.00%	2 Missing ⚠️
...planner/transit/service/DefaultTransitService.java	50.00%	2 Missing ⚠️
...lanner/ext/parkAndRideApi/ParkAndRideResource.java	0.00%	1 Missing ⚠️
...xt/vectortiles/layers/stops/StopsLayerBuilder.java	0.00%	1 Missing ⚠️
...nner/apis/transmodel/model/stop/StopPlaceType.java	0.00%	1 Missing ⚠️
... and 1 more

Additional details and impacted files

@@              Coverage Diff              @@
##             dev-2.x    #6234      +/-   ##
=============================================
+ Coverage      69.79%   69.83%   +0.03%     
- Complexity     17790    17910     +120     
=============================================
  Files           2017     2038      +21     
  Lines          76042    76484     +442     
  Branches        7781     7819      +38     
=============================================
+ Hits           53077    53410     +333     
- Misses         20263    20340      +77     
- Partials        2702     2734      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[leonardehrenfried]

Sorry for the back and forth about agency/feed id. This looks ok now.

[t2gran]

This looks good to me. Very good job on the JavaDoc, but we skip @param and @return if there is no extra information to add. We use them if there are special invariants or things like unit, to document.