Rename otp-shaded-jar artifact and fix deployment to Maven Central
#6331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The removed section was commented out by @abyrd in May 2014, and replaced later the same year with the current filter configuration (see filter config above the removed code).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6331 +/- ##
=============================================
+ Coverage 69.79% 69.82% +0.02%
- Complexity 17787 17829 +42
=============================================
Files 2017 2020 +3
Lines 76035 76269 +234
Branches 7781 7806 +25
=============================================
+ Hits 53072 53254 +182
- Misses 20260 20301 +41
- Partials 2703 2714 +11 ☔ View full report in Codecov by Sentry. |
leonardehrenfried
approved these changes
Dec 11, 2024
vpaturet
approved these changes
Dec 12, 2024
t2gran
pushed a commit
that referenced
this pull request
Dec 13, 2024
t2gran
changed the title
otp-shaded-jar artifact and fix deployment to Maven Central
t2gran
added a commit
that referenced
this pull request
Dec 13, 2024
…ifact and fix deployment to Maven Central
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add back the shaded jar as an Maven artifact.
This will keep adding the "one-jar" as an artifact to Maven Central for the next release. The doc
is updated. I updated to the next version number where apropriate, since the path in Maven Central
will change. Therefore, the new path does not exist yet - it will exist when the next release (2.7.0) is made.
Issue
This is related to #6267
Unit tests
🟥 Not relevant.
Documentation
✅ All scripts and documentation referencing the shaded jar is updated.
Changelog
✅ This is relevant for everyone maintaining OTP deployments - so to "spreed the news" we will to include this
in the chagelog - even if it is not relevant to product owners.
Bumping the serialization version id
🟥 Not needed.