Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update list of GTFS Fares v2 classes #6358

Merged

Conversation

leonardehrenfried
Copy link
Member

@leonardehrenfried leonardehrenfried commented Jan 3, 2025

Summary

This updates the GTFS entities that are part of Fares V2. These are skipped unless you enable the FaresV2 feature flag, because FaresV2 is still new and feeds frequently provide invalid data. Updating this list means that OTP will be ignoring more invalid FaresV2 data.

This PR also updates the OBA library to the latest version because previous ones had duplicate types for StopArea and Area, which are really the same thing.

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.80%. Comparing base (df53a35) to head (21f15bd).
Report is 42 commits behind head on dev-2.x.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6358      +/-   ##
=============================================
- Coverage      69.81%   69.80%   -0.01%     
  Complexity     17939    17939              
=============================================
  Files           2042     2042              
  Lines          76645    76645              
  Branches        7830     7830              
=============================================
- Hits           53506    53505       -1     
  Misses         20398    20398              
- Partials        2741     2742       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leonardehrenfried leonardehrenfried added the GTFS Related to import of GTFS data label Jan 3, 2025
Copy link
Member

@t2gran t2gran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I does not realy understand the consequences of these changes, but the PR is so smal so it should be easy to fix if there are some problems.

@leonardehrenfried leonardehrenfried merged commit be21661 into opentripplanner:dev-2.x Jan 9, 2025
5 checks passed
@leonardehrenfried leonardehrenfried deleted the faresv2-classes branch January 9, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug GTFS Related to import of GTFS data Skip Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants