Replaced concat with push for performance #513
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces instances of
d = d.concat(...)
withpush
within encoding functions for improved performance per #512. Should not impact results.Motivation and Context
This version is faster, particularly on Firefox. As a test, I ran
window.font.download()
in the console of the https://opentype.js.org/ site. In Firefox the change reduced runtime from 1,341ms to 190ms. Chrome experienced a more modest improvement from 203ms to 166ms. The ability to quickly generate custom font files is important for my project Scribe OCR, and I'm sure others as well.How Has This Been Tested?
The unit tests pass and I am using this version in my live site. Additionally, the change is conceptually simple and narrow in scope.
Types of changes
Checklist:
npm run test
and all tests passed green (including code styling checks).