TEST: updating frag pipeline env vars

openucx · Dec 7, 2022 · ab27c02 · ab27c02
1 parent e2f0e51
commit ab27c02
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/.ci/scripts/run_tests_ucc_mpi.sh b/.ci/scripts/run_tests_ucc_mpi.sh
@@ -136,7 +136,7 @@ for MT in "" "-T"; do
     echo "INFO: UCC MPI unit tests (CL/HIER+split_rail+pipeline) ..."
     # shellcheck disable=SC2086
     clhier_args=" -x UCC_CLS=basic,hier -x UCC_CL_HIER_TUNE=allreduce:@split_rail:inf -x UCC_CL_HIER_TLS=ucp -x UCC_TL_NCCL_TUNE=0 "
-    clhier_args+=" -x UCC_CL_HIER_ALLREDUCE_SPLIT_RAIL_FRAG_THRESH=0 -x UCC_CL_HIER_ALLREDUCE_SPLIT_RAIL_FRAG_SIZE=256K "
+    clhier_args+=" -x UCC_CL_HIER_ALLREDUCE_SPLIT_RAIL_PIPELINE=thresh=0:fragsize=256K "
     clhier_colls="allreduce"
     mpirun $(mpi_params $PPN) $clhier_args $EXE $MT $TG --mtypes host,cuda -c $clhier_colls
     echo "INFO: UCC MPI unit tests (CL/HIER+split_rail+pipeline) ... DONE"

diff --git a/src/utils/ucc_parser.c b/src/utils/ucc_parser.c
@@ -759,6 +759,7 @@ int ucc_config_sscanf_pipeline_params(const char *buf, void *dest,
         }
         ucc_str_split_free(t2);
     }
+    ucc_str_split_free(tokens);
     return 1;
 out:
     if (t2) {

diff --git a/test/gtest/coll/test_allreduce.cc b/test/gtest/coll/test_allreduce.cc
@@ -269,8 +269,7 @@ TYPED_TEST(test_allreduce_alg, sra_knomial_pipelined) {
     int           n_procs = 15;
     ucc_job_env_t env     = {{"UCC_CL_BASIC_TUNE", "inf"},
                              {"UCC_TL_UCP_TUNE", "allreduce:@sra_knomial:inf"},
-                             {"UCC_TL_UCP_ALLREDUCE_SRA_KN_FRAG_THRESH", "1024"},
-                             {"UCC_TL_UCP_ALLREDUCE_SRA_KN_N_FRAGS", "11"}};
+                             {"UCC_TL_UCP_ALLREDUCE_SRA_KN_PIPELINE", "thresh=1024:nfrags=11"}};
     UccJob        job(n_procs, UccJob::UCC_JOB_CTX_GLOBAL, env);
     UccTeam_h     team   = job.create_team(n_procs);
     int           repeat = 3;