CORE: change COLL_SCORE separator #142
Conversation
vspetrov
force-pushed
the
topic/score_separator
branch
from
20e565a to
b8fa565
Compare
|
After short discussion with Sergey we think we want more input from UCC people. Should we keep it ";" and then user will need to guard the string with "" in some runtimes (e.g. OMPI). Or should we change , like in this PR. This is a very minor readability question. My preference to change to # and don't think about quotes. what do other people think? |
|
will |
no, "," is already in use. Example cmd line: UCC_TL_UCP_COLL_SCORE=allreduce,barrier:cuda,host:0-1M:inf;bcast,alltoall:0 |
|
btw, since we are discussing this now: currently the parameter is called UCC_CL/TL_*_COLL_SCORE. Is "COLL" redundant" here? maybe just UCC_TL_UCP_SCORE? |
I think UCC_TL_UCP_SCORE makes sense. |
Changes scoring env var name: drop "COLL". Now the params are
called UCC_TL/CL_<name>_SCORE.
Changes separator charactor in UCC_*_SCORE parsing from ";"
to "#". The reason is that some runtimes (MPIs, e.g. OpenMPI)
incorrectly parse ";" token. W/o that change one has to always use
quote marks to guard the string.
This is just minor usability improvement.
vspetrov
force-pushed
the
topic/score_separator
branch
from
b8fa565 to
f9c97c9
Compare
Changes separator character in UCC_*_COLL_SCORE parsing from ";"
to "#". The reason is that some runtimes (MPIs, e.g. OpenMPI)
incorrectly parse ";" token. W/o that change one has to always use
quote marks to guard the string.
This is just minor usability improvement.