CORE: fix bug for triggered colls in tl/ucp #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samnordmann
force-pushed
the
bug_segfault_reduce_scatter
branch
from
1aad1ae to
b1109ec
Compare
Sergei-Lebedev
approved these changes
Mar 27, 2023
shimmybalsam
approved these changes
Mar 30, 2023
bureddy
approved these changes
Mar 31, 2023
jeniaka
pushed a commit
to jeniaka/ucc
that referenced
this pull request
Jun 21, 2023
janjust
pushed a commit
to janjust/ucc
that referenced
this pull request
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
A bug was reported by QA (#3338436)
TL/UCP reduce_scatter and reduce_scatterv on CUDA using triggered mode cause a segfault.
This is because
schedule->super.triggered_postis not set on the schedule.How ?
Since all the tasks must set
task.triggered_post=ucc_triggered_post, this is done inucc_coll_task_init.Only TL/NCCL and TL/RCCL will overwrite this field.