Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TL/UCP: fix sparse pack in hybrid a2av #825

Merged
merged 1 commit into from
Aug 24, 2023
Merged

TL/UCP: fix sparse pack in hybrid a2av #825

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/components/tl/ucp/alltoallv/alltoallv_hybrid.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,6 @@ static size_t pack_send_data(ucc_tl_ucp_task_t *task, int step,
int n = send_count;
int logi = 1;
void *op_metadata = task->alltoallv_hybrid.scratch_mc_header->addr;

ucc_rank_t index;
int send_len, snd_offset, i, k;
unsigned int temp_count;
Expand Down Expand Up @@ -365,7 +364,7 @@ static size_t pack_send_data(ucc_tl_ucp_task_t *task, int step,
/* if there is data for less than half the destinations, send meta data
* in sparse format.
*/
if ((sparse_cnt / 2) < send_count) {
if ((sparse_cnt * 2) < send_count) {
/* sparse format: store nonzero messages and source rank index */
((unsigned int *)packed_send_buf)[0] = sparse_cnt;
/* compute space requirement for sparse data exchange header */
Expand Down