Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UCS/UCT: Fix issues found by coverity. #18

Merged
merged 1 commit into from
Nov 5, 2014

Conversation

yosefe
Copy link
Contributor

@yosefe yosefe commented Nov 5, 2014

No description provided.

@mellanox-github
Copy link
Contributor

Merged build triggered.

1 similar comment
@mellanox-github
Copy link
Contributor

Merged build triggered.

@mellanox-github
Copy link
Contributor

Merged build started.

@mellanox-github
Copy link
Contributor

Merged build finished. Test FAILed.

@mellanox-github
Copy link
Contributor

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com:8000/jenkins-secure/job/gh-ucx-pr/4/

Build Log
last 50 lines

[...truncated 514 lines...]
  CC       debug/log.lo
  CC       debug/memtrack.lo
  CC       stats/stats.lo
  CC       sys/math.lo
  CC       sys/sys.lo
  CC       time/time.lo
  CC       time/timer_wheel.lo
  CC       time/timerq.lo
  CC       type/callback.lo
  CC       type/component.lo
  CC       type/status.lo
  CCLD     libucs.la
make[2]: Leaving directory `/scrap/jenkins/jenkins/jobs/gh-ucx-pr/workspace/src/ucs'
Making all in src/uct
make[2]: Entering directory `/scrap/jenkins/jenkins/jobs/gh-ucx-pr/workspace/src/uct'
  CC       tl/libuct_la-context.lo
  CC       tl/libuct_la-tl.lo
  CC       ib/base/libuct_la-ib_context.lo
  CC       ib/base/libuct_la-ib_device.lo
  CC       ib/base/libuct_la-ib_iface.lo
  CC       ib/rc/libuct_la-rc_iface.lo
  CC       ib/rc/libuct_la-rc_tl.lo
  CCLD     libuct.la
make[2]: Leaving directory `/scrap/jenkins/jenkins/jobs/gh-ucx-pr/workspace/src/uct'
make[2]: Entering directory `/scrap/jenkins/jenkins/jobs/gh-ucx-pr/workspace'
make[2]: Leaving directory `/scrap/jenkins/jenkins/jobs/gh-ucx-pr/workspace'
make[1]: Leaving directory `/scrap/jenkins/jenkins/jobs/gh-ucx-pr/workspace'
+ make -j15 distcheck
make  dist-gzip am__post_remove_distdir='@:'
make[1]: Entering directory `/scrap/jenkins/jenkins/jobs/gh-ucx-pr/workspace'
make[1]: *** No rule to make target `m4/gtest.m4', needed by `distdir'.  Stop.
make[1]: Leaving directory `/scrap/jenkins/jenkins/jobs/gh-ucx-pr/workspace'
make: *** [dist] Error 2
Build step 'Execute shell' marked build as failure
TAP Reports Processing: START
Looking for TAP results report in workspace using pattern: **/*.tap
Did not find any matching files.
[Valgrind] Files to copy:
[Valgrind] Analysing valgrind results
[Valgrind] Ending the valgrind analysis.
Anchor chain: could not read file with links: /var/lib/jenkins/jobs/gh-ucx-pr/workspace/jenkins_sidelinks.txt (No such file or directory)
[copy-to-slave] The build is taking place on the master node, no copy back to the master will take place.
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Request made to compress build log
Sending email to: eugene@mellanox.com miked@mellanox.com yosefe@mellanox.com
[BFA] Scanning build for known causes...

[BFA] Done. 0s

Test FAILed.

* Return value from ucs_memtrack_mmap should be MAP_FAILED and not NULL
* Fix error flow in ucs_init
@yosefe yosefe force-pushed the topic/fix-coverity branch from a6ef6b3 to 16d008a Compare November 5, 2014 09:27
@mellanox-github
Copy link
Contributor

Merged build triggered.

1 similar comment
@mellanox-github
Copy link
Contributor

Merged build triggered.

@mellanox-github
Copy link
Contributor

Merged build started.

@mellanox-github
Copy link
Contributor

Merged build finished. Test FAILed.

@mellanox-github
Copy link
Contributor

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com:8000/jenkins-secure/job/gh-ucx-pr/5/

Build Log
last 50 lines

[...truncated 514 lines...]
  CC       debug/log.lo
  CC       debug/memtrack.lo
  CC       stats/stats.lo
  CC       sys/math.lo
  CC       sys/sys.lo
  CC       time/time.lo
  CC       time/timer_wheel.lo
  CC       time/timerq.lo
  CC       type/callback.lo
  CC       type/component.lo
  CC       type/status.lo
  CCLD     libucs.la
make[2]: Leaving directory `/scrap/jenkins/jenkins/jobs/gh-ucx-pr/workspace/src/ucs'
Making all in src/uct
make[2]: Entering directory `/scrap/jenkins/jenkins/jobs/gh-ucx-pr/workspace/src/uct'
  CC       tl/libuct_la-tl.lo
  CC       tl/libuct_la-context.lo
  CC       ib/base/libuct_la-ib_context.lo
  CC       ib/base/libuct_la-ib_device.lo
  CC       ib/base/libuct_la-ib_iface.lo
  CC       ib/rc/libuct_la-rc_tl.lo
  CC       ib/rc/libuct_la-rc_iface.lo
  CCLD     libuct.la
make[2]: Leaving directory `/scrap/jenkins/jenkins/jobs/gh-ucx-pr/workspace/src/uct'
make[2]: Entering directory `/scrap/jenkins/jenkins/jobs/gh-ucx-pr/workspace'
make[2]: Leaving directory `/scrap/jenkins/jenkins/jobs/gh-ucx-pr/workspace'
make[1]: Leaving directory `/scrap/jenkins/jenkins/jobs/gh-ucx-pr/workspace'
+ make -j15 distcheck
make  dist-gzip am__post_remove_distdir='@:'
make[1]: Entering directory `/scrap/jenkins/jenkins/jobs/gh-ucx-pr/workspace'
make[1]: *** No rule to make target `m4/gtest.m4', needed by `distdir'.  Stop.
make[1]: Leaving directory `/scrap/jenkins/jenkins/jobs/gh-ucx-pr/workspace'
make: *** [dist] Error 2
Build step 'Execute shell' marked build as failure
TAP Reports Processing: START
Looking for TAP results report in workspace using pattern: **/*.tap
Did not find any matching files.
[Valgrind] Files to copy:
[Valgrind] Analysing valgrind results
[Valgrind] Ending the valgrind analysis.
Anchor chain: could not read file with links: /var/lib/jenkins/jobs/gh-ucx-pr/workspace/jenkins_sidelinks.txt (No such file or directory)
[copy-to-slave] The build is taking place on the master node, no copy back to the master will take place.
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Request made to compress build log
Sending email to: eugene@mellanox.com miked@mellanox.com yosefe@mellanox.com
[BFA] Scanning build for known causes...

[BFA] Done. 0s

Test FAILed.

mike-dubman added a commit that referenced this pull request Nov 5, 2014
UCS/UCT: Fix issues found by coverity.
@mike-dubman mike-dubman merged commit 0b71411 into openucx:master Nov 5, 2014
@mike-dubman mike-dubman deleted the topic/fix-coverity branch November 5, 2014 11:23
@yosefe
Copy link
Contributor Author

yosefe commented Nov 5, 2014

reviewed by @miked-mellanox

@shamisp
Copy link
Contributor

shamisp commented Nov 5, 2014

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants