Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UCT/CUDA_IPC: make cuda-ipc cache global - v1.10.x #6364

Merged

Conversation

Akshay-Venkatesh
Copy link
Contributor

What

Backport of #5815 and #6360

@Akshay-Venkatesh
Copy link
Contributor Author

cc @yosefe @pentschev

@swx-jenkins3
Copy link
Collaborator

Can one of the admins verify this patch?

@yosefe
Copy link
Contributor

yosefe commented Feb 18, 2021

ok to test

@yosefe
Copy link
Contributor

yosefe commented Feb 18, 2021

@Akshay-Venkatesh was this clean cherry pick?

@Akshay-Venkatesh
Copy link
Contributor Author

@Akshay-Venkatesh was this clean cherry pick?

@yosefe I took https://github.com/openucx/ucx/pull/5815.diff and https://github.com/openucx/ucx/pull/6360.diff and patched in that order as all changes were in uct/cuda/cuda_ipc. I didn't see any issues in build/tests.

Copy link
Contributor

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just tested this and didn't experience any regressions as well. Thanks @Akshay-Venkatesh !

@yosefe yosefe changed the title UCT/CUDA_IPC: make cuda-ipc cache global UCT/CUDA_IPC: make cuda-ipc cache global - v1.10.x Feb 19, 2021
@yosefe yosefe merged commit fdaf339 into openucx:v1.10.x Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants