UCP/EP: Add eager multi-fragment overhead #7967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artemy-Mellanox
force-pushed
the
topic/fuj_perf_old
branch
from
e7b8cfc to
07791cf
Compare
yosefe
reviewed
Feb 27, 2022
|
|
||
| if (eager) { | ||
| params->bw += 1.0 / ((1.0 / bw) + (iface_attr->overhead / | ||
| iface_attr->cap.am.max_bcopy)); |
There was a problem hiding this comment.
is it possible max_bcopy would be 0?
src/ucp/core/ucp_ep.c
Outdated
| bw = ucp_tl_iface_bandwidth(context, &iface_attr->bandwidth); | ||
|
|
||
| if (eager) { | ||
| params->bw += 1.0 / ((1.0 / bw) + (iface_attr->overhead / |
There was a problem hiding this comment.
pls add comment:
/* eager protocol has overhead for each fragment */
There was a problem hiding this comment.
use
overhead = send_post_overhead + send_pre_overhead (from estimate_perf)
| @@ -1749,7 +1751,14 @@ static void ucp_ep_config_calc_params(ucp_worker_h worker, | |||
| } | |||
| } | |||
|
|
|||
| params->bw += ucp_tl_iface_bandwidth(context, &iface_attr->bandwidth); | |||
| bw = ucp_tl_iface_bandwidth(context, &iface_attr->bandwidth); | |||
|
|
|||
| @@ -360,13 +360,21 @@ void test_ucp_peer_failure::do_test(size_t msg_size, int pre_msg_count, | |||
| EXPECT_NE(UCS_OK, m_err_status); | |||
|
|
|||
| if (UCS_PTR_IS_PTR(sreq)) { | |||
| /* The request may either succeed or fail, even though the data is | |||
| ucs_status_t status; | |||
| /* TODO update comment | |||
There was a problem hiding this comment.
- why needed? if m_err_count!=0, i would expect the request to also complete
- update comment
- can we use request_wait()?
There was a problem hiding this comment.
discussed offline:
- use request_wait
- update comment: "If rendezvous protocol is used, the m_err_count is increased on the receiver side, so the send request may not complete immediately"
yosefe
reviewed
Mar 1, 2022
Artemy-Mellanox
force-pushed
the
topic/fuj_perf_old
branch
2 times, most recently
from
df01e95 to
987b782
Compare
yosefe
reviewed
Mar 2, 2022
src/ucp/core/ucp_ep.c
Outdated
Comment on lines
1767
to
1768
| status = uct_iface_estimate_perf(wiface->iface, &perf_attr); | ||
| ucs_assert(status == UCS_OK); |
yosefe
previously approved these changes
Mar 3, 2022
| @@ -1812,17 +1826,23 @@ static size_t ucp_ep_config_calc_rndv_thresh(ucp_worker_t *worker, | |||
| (2 * eager_zcopy.overhead) + rndv.overhead) - | |||
| eager_zcopy.reg_overhead - eager_zcopy.overhead; | |||
|
|
|||
| denumerator = eager_zcopy.reg_growth + | |||
| denominator = eager_zcopy.reg_growth + | |||
|
@Artemy-Mellanox can you pls squash? |
Artemy-Mellanox
force-pushed
the
topic/fuj_perf_old
branch
from
f30107e to
68499ec
Compare
yosefe
approved these changes
Mar 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.