Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Popup] Storing the activating element relationship #358

Closed
melanierichards opened this issue Jun 18, 2021 · 2 comments
Closed

[Popup] Storing the activating element relationship #358

melanierichards opened this issue Jun 18, 2021 · 2 comments
Assignees
@melanierichards
Labels
needs edits This is ready for edits to be made popover The Popover API

Comments

@melanierichards
Copy link
Collaborator

melanierichards commented Jun 18, 2021 •
edited
Loading

A popup element can be shown via user interaction with another element whose popup attribute references the popup element ID. For example, upon invocation of this button:

<button popup="myMenu">Menu</button>
<popup id="myMenu">...</popup>

We need to specify some way of storing the relationship between these two elements once the popup is shown, for purposes of deciding whether to hide a popup.

Per @mfreed7: in the Chromium implementation, I've stored this on the HTMLPopupElement, and I called it the "invoker".

This issue will track discussions on what implementer (user agent) guidance to provide in the spec for storing this relationship.
@melanierichards melanierichards added the popover The Popover API label Jun 18, 2021
@melanierichards melanierichards mentioned this issue Jun 18, 2021
Merged
@una una added the agenda+ Use this label if you'd like the topic to be added to the meeting agenda label Jun 23, 2021
@una
Copy link
Collaborator

una commented Jul 1, 2021

RESOLVED: Popups need an internal invoker relationship. Add guidance to popup specification for storing the invoker relationship.

@melanierichards melanierichards added the needs edits This is ready for edits to be made label Jul 1, 2021
@melanierichards melanierichards self-assigned this Jul 1, 2021
melanierichards pushed a commit to melanierichards/open-ui that referenced this issue Jul 1, 2021
[Popup] 2021.07.01 checkpoint in addressing PR feedback (also addresses
5e04a4e 
openui#358)
melanierichards pushed a commit to melanierichards/open-ui that referenced this issue Jul 2, 2021
[Popup] 2021.07.01 checkpoint in addressing PR feedback (also addresses
252119e 
openui#358)
@gregwhitworth gregwhitworth removed the agenda+ Use this label if you'd like the topic to be added to the meeting agenda label Jul 20, 2021
gregwhitworth pushed a commit that referenced this issue Aug 26, 2021
@melanierichards @domenic
Add first draft of Popup (Editor's Draft) (#355)
e8baeb4 
* [Popup spec] Add brief intro with HTML-esque metadata

* [Popup] Fix up frontmatter

* [Popup] Add spec outline

* [Popup] Add initiallyopen attribute (addresses #311)

* [Popup] Add show() method

* [Popup] Convert a note to a todo

* [Popup] Add popup attribute

* [Popup] Hide currently-shown popup elements steps

* [Popup] Setting focus when the popup element is shown

* [Popup] Hiding a popup element

* [Popup] Componentize 'showing a popup element steps'

* [Popup] Various and sundry edits

* [Popup] Address first ~half of first round of feedback

* [Popup] 2021.07.01 checkpoint in addressing PR feedback (also addresses #358)

* [Popup] 2021.07.02 spec updates

* [Popup] First batch of updates to HTML editor feedback

* Apply suggestions from HTML editor code review

Co-authored-by: Domenic Denicola <d@domenic.me>

* 2021.08.24 batch of popup updates for HTML editor feedback

Co-authored-by: Domenic Denicola <d@domenic.me>
@melanierichards
Copy link
Collaborator Author

This resolution was satisfied when #355 was merged in; closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melanierichards melanierichards

Labels
needs edits This is ready for edits to be made popover The Popover API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@melanierichards @gregwhitworth @una