-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add draft for File input #140
Conversation
@mrmckeb could you join the WICG to appease the IPR bots? |
Hi @yoavweiss, thanks for the note. I did - after creating this PR - but it doesn't seem to have updated... maybe the bot can be re-run? |
Re-ran the bots and they seem to like you now :) Welcome!! |
The stars have aligned, thanks @yoavweiss! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your time on this. I requested a few issues to be opened for group discussion.
Can you please add in an events section that shows which events are tied to which parts and their resulting impacts on the various other states and parts? Here is an example of this in <select>
https://open-ui.org/components/select#events-1
ping @mrmckeb any update on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some feedback on some minor tweeks and an additional issue or two for further discussion. Thanks for taking the time on this - it looks good.
@mrmckeb gentle ping, any update? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gregwhitworth, I'll wait for @una's review and then make the final changes! Looking forward to getting this in :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some errors in the console that relate to the anatomy. Can you please ensure that those are addressed. We're almost there, only a few small changes. Thank you again for your work on this.
Thanks @gregwhitworth, this is updated, and squashed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the comment regarding the resolution of the tabbing behavior for #248. I don't want to block that edit on this PR but if you can submit a new PR once this one lands with that resolved change.
Thanks @gregwhitworth - I can make that change as soon as this lands. |
LGTM, nice breakdown |
Relates to PR #92, issue #114.