-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scopedRegistries is not removed when remove all dependencies #153
Comments
@TylerTemp, thank you for reporting the bug. It's a known issue that was partly addressed by #134. However, it appears we forgot the |
@all-contributors please add @TylerTemp for bug. |
I've put up a pull request to add @TylerTemp! 🎉 |
favoyang
pushed a commit
that referenced
this issue
Mar 5, 2024
* test: add establishing tests Add tests to establish the behaviour described in #153. * feat: manifest prune logic Add helper function to prune manifest. This removes scoped-registries without scopes. * feat: prune manifest before saving Prune manifest before saving to file-system.
Fixed by #157, thanks @ComradeVanti. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
openupm add today.comes.saintsfield
openupm remove today.comes.saintsfield
Expected Behavior
When all dependencies removed, the item in
scopedRegistries
inPackages/manifest.json
gets removed too:"scopedRegistries": [ ]
Actual Behavior
The registry of openupm is still there with empty scopes, and lead to error:
Version
The text was updated successfully, but these errors were encountered: