enable icalc for set operations #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…have dummy parameter but useful for precommand)
h0nIg
commented
Sep 10, 2022
| @@ -574,27 +574,24 @@ int procSetUnit(unitPtr uPtr, char *sendBuf, short *sendLen, char bitpos, char * | |||
| inPtr = uPtr->sICalc; | |||
| if (uPtr->ePtr) { | |||
| // There are enums | |||
| if (! *input) { | |||
There was a problem hiding this comment.
same input check in line 553
h0nIg
changed the title
|
The calc/icalc approach shows its problems here, but your solution offers some useful possibilites. Just for reference to keep pull requests linked on GH: #109 |
|
ping @speters |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
required for openv/openv#480 (comment)