Fix phonetics for 啞 #590
Merged
Fix phonetics for 啞 #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The concise dictionary prefers `啞啞 ㄧㄚ ㄧㄚ`. Note that `黃蓮` is a common incorrect form for `黃連`. Ref: https://dict.concised.moe.edu.tw/search.jsp?md=1&word=%E5%95%9E#searchL https://www.moedict.tw/%E9%BB%83%E9%80%A3
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (2)
- Source/Data/BPMFMappings.txt: Language not supported
- Source/Data/phrase.occ: Language not supported
lukhnos
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The concise dictionary prefers
啞啞 ㄧㄚ ㄧㄚ.Note that
黃蓮is a common incorrect form for黃連.Ref:
https://dict.concised.moe.edu.tw/search.jsp?md=1&word=%E5%95%9E#searchL https://www.moedict.tw/%E9%BB%83%E9%80%A3
Summary by Bito
This pull request enhances the dictionary by introducing phonetic corrections for specific terms, particularly '啞', and updates BPMF mappings and phrase entries to improve usability and correctness.Unit tests added: False
Estimated effort to review (1-5, lower is better): 2 - The changes are straightforward and primarily involve updates to existing mappings, making the review process relatively simple.