Make user phrase scores fairer via rewriting #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #118. To avoid single-syllable user unigrams dominating the grid walk when there are competing multi-syllable unigrams, we assign a fairer score to such user unigrams instead of the default value of 0.
lukhnos
force-pushed
the
dev/fairer-user-phrase-scores
branch
from
6a1e9ad to
3f9392c
Compare
zonble
requested changes
Feb 19, 2024
| allUnigrams.insert(allUnigrams.begin(), userUnigrams.begin(), userUnigrams.end()); | ||
| // This relies on the fact that we always use the default separator. | ||
| bool isKeyMultiSyllable = key.find(Formosa::Gramambular2::ReadingGrid::kDefaultSeparator) != std::string::npos; | ||
| if (isKeyMultiSyllable || allUnigrams.empty()) { |
There was a problem hiding this comment.
I guess we may need to comment on why multi syllables phrases should be always in the front without scoring. I cannot understand its purpose when I read the code.
There was a problem hiding this comment.
Clarified the motivation in 4d9db9c. PTAL.
There was a problem hiding this comment.
Or even better, introducing a new feature of having -inf in the file and the code.
|
Look good :) |
lukhnos
added a commit
to openvanilla/McBopomofo
that referenced
this pull request
Feb 20, 2024
This carries over the following changes: - openvanilla/fcitx5-mcbopomofo#119 - openvanilla/fcitx5-mcbopomofo#120 - openvanilla/fcitx5-mcbopomofo#121
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #118. To avoid single-syllable user unigrams dominating the grid walk when there are competing multi-syllable unigrams, we assign a fairer score to such user unigrams instead of the default value of 0.